|
From: Илья Ш. <chi...@gm...> - 2017-12-29 10:11:22
|
thank for the patch. not directly related to the patch itself, but openvpn is shipped with several memory debugging options --with-mem-check=TYPE build with debug memory checking should we get rid of them (in favour of sanitizers) ? or, maybe add to tests instead ? 2017-12-29 14:47 GMT+05:00 Steffan Karger <ste...@fo...>: > The clang address sanitizer is able to catch quite a number of > memory-related bugs, such add memory leaks and buffer under/overruns. > So, enable the address sanitizer for one openssl and one mbedtls build. > > This would have caught the buffer list unittest memory leak that > <151...@ka...> wants to fix. > > Signed-off-by: Steffan Karger <ste...@fo...> > --- > .travis.yml | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/.travis.yml b/.travis.yml > index 1f669b3..99cd5e2 100644 > --- a/.travis.yml > +++ b/.travis.yml > @@ -33,7 +33,7 @@ matrix: > - env: SSLLIB="openssl" OPENSSL_VERSION="1.1.0f" > os: linux > compiler: gcc > - - env: SSLLIB="openssl" > + - env: SSLLIB="openssl" CFLAGS="-fsanitize=address" > os: linux > compiler: clang > - env: SSLLIB="openssl" OPENSSL_VERSION="1.1.0f" > @@ -42,7 +42,7 @@ matrix: > - env: SSLLIB="mbedtls" > os: linux > compiler: gcc > - - env: SSLLIB="mbedtls" > + - env: SSLLIB="mbedtls" CFLAGS="-fsanitize=address" > os: linux > compiler: clang > - env: SSLLIB="openssl" > -- > 2.7.4 > > > ------------------------------------------------------------ > ------------------ > Check out the vibrant tech community on one of the world's most > engaging tech sites, Slashdot.org! http://sdm.link/slashdot > _______________________________________________ > Openvpn-devel mailing list > Ope...@li... > https://lists.sourceforge.net/lists/listinfo/openvpn-devel > |