Re: [Openvpn-devel] [PATCH] openvpnserv: Add support for multi-instances

[Selva <sel...@gm...>]

Hi Simon,

On Thu, Nov 2, 2017 at 3:21 PM, Simon Rozman <si...@ro...> wrote:

> While openvpn.exe can run multiple concurrent processes, openvpnserv.exe
> is usually only one single globally unique running process.
>
> This patch extends openvpnserv.exe to support multiple service instances
> in parallel allowing side-by-side OpenVPN installations.
>

That was fast. On a quick glance, looks good but the patch does not apply
on current master. Did you base it on some of your recent patches not
all of which are yet merged? Looks like the contexts in common.c and
interactive.c do not match so the patch fails.

Hi,
>
> RegisterServiceCtrlHandlerEx() is obviously happy with any service

name for `SERVICE_WIN32_OWN_PROCESS` service types. I have

tested it.
>

Oh, really? I didn't think that would be the case. Looking at the docs
again,
the older non-Ex variant (RegisterServiceCtrlHandler()) does state that the
name is not checked in case of OWN_PROCESS. Probably that got carried
over to the ...Ex() though not documented as such.

Cheers,

Selva