Re: [Openvpn-devel] [PATCH] add PR template in order to simplify new developers cooperate properly if they open PR. discussed here: https://sourceforge.net/p/openvpn/mailman/message/35601310/

[Samuli S. <sa...@op...>]

I agree with you on keeping the pull request template minimal and having 
the more fine-grained information in Trac.

ACK.

On 30/01/2017 08:48, Илья Шипицин wrote:
> can we merge it ?
> @mattock ?
>
> 2017-01-21 13:47 GMT+05:00 Илья Шипицин <chi...@gm...
> <mailto:chi...@gm...>>:
>
>
>
>     2017-01-21 0:24 GMT+05:00 David Sommerseth
>     <op...@sf...
>     <mailto:op...@sf...>>:
>
>         On 13/01/17 10:05, Samuli Seppänen wrote:
>         > Il 13/01/2017 10:50, Ilya Shipitsin ha scritto:
>         >> ---
>         >>  .github/PULL_REQUEST_TEMPLATE.md | 8 ++++++++
>         >>  1 file changed, 8 insertions(+)
>         >>  create mode 100644 .github/PULL_REQUEST_TEMPLATE.md
>         >>
>         >> diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md
>         >> new file mode 100644
>         >> index 0000000..d0cfd7f
>         >> --- /dev/null
>         >> +++ b/.github/PULL_REQUEST_TEMPLATE.md
>         >> @@ -0,0 +1,8 @@
>         >> +# Thank you for your contribution
>         >> +
>         >> +You are welcome to open PR, but they are used for discussion only. All
>         >> +patches must eventually go to the openvpn-devel mailing list for review.
>         >> +For details, see these Wiki articles:
>         >> +
>         >> +* https://community.openvpn.net/openvpn/wiki/Contributing
>         <https://community.openvpn.net/openvpn/wiki/Contributing>
>         >> +* https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation <https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation>
>         >>
>         >
>         > Based on testing in the travis-openssl-test repository the template
>         > works as intended, so ACK on that part.
>         >
>         > Any comments on the text itself?
>
>         How does this work with branches?  Do we need to say that new
>         patches
>         should go into the master branch primarily, unless it is fixing
>         a bug or
>         another issue which is only relevant for specific release branches?
>
>
>
>     we can put such information to
>
>     https://community.openvpn.net/openvpn/wiki/Contributing
>     <https://community.openvpn.net/openvpn/wiki/Contributing>
>     https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation
>     <https://community.openvpn.net/openvpn/wiki/DeveloperDocumentation>
>
>
>     I would leave PR template skinny
>
>
>
>
>         --
>         kind regards,
>
>         David Sommerseth
>         OpenVPN Technologies, Inc
>
>
>
>


-- 
Samuli Seppänen
Community Manager
OpenVPN Technologies, Inc

irc freenode net: mattock