From: Gert D. <ge...@gr...> - 2017-01-18 21:21:32
|
Hi, On Wed, Jan 18, 2017 at 03:42:52PM -0500, sel...@gm... wrote: > From: Selva Nair <sel...@gm...> > > - Also make tests that require --wrap option to be > conditional on this support > > Signed-off-by: Selva Nair <sel...@gm...> I said so in the PR already, but for the sake of the list - I think this is a reasonable approach: disable the --wrap tests if we can't run them, but keep the rest of the cmocka stuff active (way better than my initial "if it's not GNU ld, just disable cmocka"). I'm ready and willing to ACK and merge this, but would like to hear some voices from folks that understand autoconf better - is there anything wrong with this approach? Any suggestions how to do it better? gert -- USENET is *not* the non-clickable part of WWW! //www.muc.de/~gert/ Gert Doering - Munich, Germany ge...@gr... fax: +49-89-35655025 ge...@ne... |