Re: [Openvpn-devel] [PATCH (master)] Drop gnu89/c89 support, switch to c99

[Gert D. <ge...@gr...>]

Hi,

On Mon, Aug 29, 2016 at 11:03:00PM +0200, David Sommerseth wrote:
>  -std=c89
>    Makes the LZ4 library we're shipping explode.

We could fix that, but right now the LZ4 sources are "very close to
upstream" (just a few file and #include renames) so that would make
comparison "are these sane sources or have they been tampered with"
less easy.

But I think -std=c89 would also break stuff that we really want, like

 for( int i=0; i<10; i++)
      ^^^

... which really makes "this is the loop variable and nothing else"
much easier to read than having an "int i" 50+ lines earlier in the code...

gert

-- 
USENET is *not* the non-clickable part of WWW!
                                                           //www.muc.de/~gert/
Gert Doering - Munich, Germany                             ge...@gr...
fax: +49-89-35655025                        ge...@ne...