Re: [Openvpn-devel] [PATCH] Report missing endtags of inline files as warnings

[Arne S. <ar...@rf...>]

Am 29.06.15 um 20:22 schrieb Gert Doering:
> Hi,
>
> On Mon, Jun 29, 2015 at 02:46:35PM +0200, Arne Schwabe wrote:
>>  	}
>>        buf_printf (&buf, "%s", line);
>>      }
>> +  if (!endtagfound)
>> +    msg (M_WARN, "WARNING: Endtag %s missing", close_tag);
> Generally speaking, ACK.  I wonder whether this should be M_WARN or
> M_FATAL, though?
>
> Tested, nicely reports the missing </key> in my test case, but then
> proceeds to "not do what the user intended"...
>
> (Can't commit it anyway, as mid.gmane.org is not giving me URLs right now...)
>
Maybe M_WARN for 2.3, M_FATAL for 2.4?

Arne