Re: [Openvpn-devel] [PATCH] polarssl: fix unreachable code

[Steffan K. <st...@ka...>]

ACK. Harmless, but definitely an oversight.

-Steffan

On 23-11-14 13:21, Yegor Yefremov wrote:
> Found via cppcheck and compile-tested.
> 
> Signed-off-by: Yegor Yefremov <yeg...@go...>
> ---
>  src/openvpn/ssl_polarssl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/openvpn/ssl_polarssl.c b/src/openvpn/ssl_polarssl.c
> index b026a17..2036885 100644
> --- a/src/openvpn/ssl_polarssl.c
> +++ b/src/openvpn/ssl_polarssl.c
> @@ -846,8 +846,8 @@ key_state_write_plaintext (struct key_state_ssl *ks, struct buffer *buf)
>  
>    if (0 == buf->len)
>      {
> -      return 0;
>        perf_pop ();
> +      return 0;
>      }
>  
>    retval = ssl_write(ks->ctx, BPTR(buf), buf->len);
>