Re: [Openvpn-devel] [PATCH] fix 2.2.0 build failure when management interface disabled

[Matthias A. <mat...@gm...>]

Am 14.05.2011 14:03, schrieb Gert Doering:
> Hi,
> 
> On Wed, May 11, 2011 at 05:57:28PM -0400, Matthew L. Creech wrote:
>> I just upgraded to 2.2.0, and my build fails with:
>>
>> ps.c: In function 'port_share_open':
>> ps.c:778:7: error: 'management' undeclared (first use in this function)
>> ps.c:778:7: note: each undeclared identifier is reported only once for
>> each function it appears in
>> make[5]: *** [ps.o] Error 1
> 
> Thanks for reporting it.  As far as I can see, this problem came in via
> c7dd80cf45efa (aka 2.1.3s), and that is obviously only needed if management
> is enabled.
> 
> So: ACK from me.
> 
> Samuli: we need buildbot variants with/without management, it seems...

Cutting down complexity (i. e. cutting out branches in the decision
and/or option trees) is going to help more than just trying to cure the
symptoms.

-- 
Matthias Andree