|
From: Mathias S. <ma...@op...> - 2005-12-01 14:09:16
|
On Thu, 1 Dec 2005, James Yonan wrote: > On Wed, 30 Nov 2005, Mathias Sundman wrote: > >> On Wed, 30 Nov 2005, Mathias Sundman wrote: >> >>> On Wed, 30 Nov 2005, Jon Bendtsen wrote: >>> >>>> Sundman from #openvpn had some suggestions and they appears to be working. >>>> i had to remove the pull/client statement from the client.conf and run this >>>> manually >>>> sudo ifconfig tun0 192.168.123.253/24 192.168.123.253 >>>> sudo route add -net 192.168.123.0 192.168.123.253 255.255.255.0 >>>> >>>> It does work. >>>> I can ping, and if i add a route to the network beyond the VPN network i >>>> can >>>> ping and surf on those hosts as well >>>> sudo route add -net 192.168.119.0 192.168.123.34 255.255.255.0 >>>> >>>> So topology does work on mac OSX. >>> >>> Alright Jon, try this patch and see if it helps... >>> >>> It tries to use the following syntax for --dev tun --topology subnet on mac >>> OSX: >>> >>> ifconfig tun0 192.168.123.253 192.168.123.253 netmask 255.255.255.0 mtu xxx >>> up >>> >>> instead of previous >>> ifconfig tun0 192.168.123.253 netmask 255.255.255.0 mtu xxx up >>> that didn't work... >> >> My last patch had a typo, attached is a working one. Jon has verified that >> the patch does work on macOSX. >> >> The tun interface now gets its IP and mask set, but to reach the whole >> subnet assigned to the tun interface he still had to add a route as above: >> >> route add -net 192.168.123.0 192.168.123.253 255.255.255.0 >> >> So, the question is, should we make OpenVPN always add a network route for >> the "local network" assigned to the tun interface when in --dev tun, >> --topology subnet mode on macOSX, or is it up to the user to push such a >> route? >> >> How does other OSs work? If we push such a route, we don't want to break >> other OSs... > > No, I don't think we should universally push a route, since that will > break platforms which don't need the extra route in the first place (like > Linux or Windows). > > I think it would be better if the OpenVPN client generates the "route add" > by itself, on platforms where the tun/tap driver can't accept a netmask in > tun mode. Okay, attached is a new patch that adds this route automatically. Could you please try it Jon. James, now I simply called add_route() directly from do_ifconfig(). Perhaps you would have prefered to do the route addition at some other stage or just have added the route to the route add list instead. -- _____________________________________________________________ Mathias Sundman (^) ASCII Ribbon Campaign OpenVPN GUI for Windows X NO HTML/RTF in e-mail http://openvpn.se/ / \ NO Word docs in e-mail |