Menu

#100 Access to Directions field in Postal Addresses

Version 1.0
closed
nobody
None
5
2007-08-03
2007-07-24
No

Need GUI access to the Directions field in Postal Addresses (create/ edit contact mech of type "postal address")
Textarea control.

The need came when working on an implementation in an African country where streets don't always have names, homes usually don't have numbers, postal addresses are usually reduced to a PO Box, and people use directions such as "next to the gas station".

CONTRIBUTION
I attach a patch that:
- gives UI access to the "directions" field
- displays the field.

Discussion

  • Eric Jacolin

    Eric Jacolin - 2007-07-24
     
  • Si Chen

    Si Chen - 2007-07-25

    Logged In: YES
    user_id=908761
    Originator: NO

    I think this is a good idea. Where is {uiLabelMap.Directions} defined?

     
  • Eric Jacolin

    Eric Jacolin - 2007-07-26

    Logged In: YES
    user_id=1808441
    Originator: YES

    You're right, it is not yet defined

    I reckon the place it belongs is
    applications/party/config/PartyUiLabels.properties

     
  • Si Chen

    Si Chen - 2007-07-27

    Logged In: YES
    user_id=908761
    Originator: NO

    If you also modify the ofbiz screens then go ahead and put the ui label there. Otherwise I don't know if they'll want ui labels for things not in their apps. You/we can put it into opentaps-commons for now in that case.

     
  • Eric Jacolin

    Eric Jacolin - 2007-07-27

    Logged In: YES
    user_id=1808441
    Originator: YES

    Well, it is already in the Ofbiz app - the entity exists albeit at present there is no UI access thereto. So it should be OK to patch upstream at the Ofbiz level. No need to augment opentaps-commons needlessly.

     
  • Si Chen

    Si Chen - 2007-07-31

    Logged In: YES
    user_id=908761
    Originator: NO

    Sorry but this patch does not match up to the files currently in opentaps. Have you tried merging recently? If so, do you have a more up-to-date one?

     
  • Eric Jacolin

    Eric Jacolin - 2007-08-01
     
  • Eric Jacolin

    Eric Jacolin - 2007-08-01

    Logged In: YES
    user_id=1808441
    Originator: YES

    Yep - patch conflicted with a recent commit.

    Attached is modified patch (contactmech-2.patch)
    File Added: contactmech-2.patch

     
  • Si Chen

    Si Chen - 2007-08-03
    • status: open --> closed
     
  • Si Chen

    Si Chen - 2007-08-03

    Logged In: YES
    user_id=908761
    Originator: NO

    Thanks, I committed this. Also I made a slight change to the layout by putting the directions below the full address.

     
  • Jacques Le Roux

    Jacques Le Roux - 2007-08-11

    Logged In: YES
    user_id=1207036
    Originator: NO

    Please Eric, could you submit your patch in https://issues.apache.org/jira/browse/OFBIZ-961 ?

    I will be happy to commit it. Thanks

     

Log in to post a comment.

MongoDB Logo MongoDB