#3 'lookup' doesnt function for $RELATED_TLDS if SSL is used

open
nobody
5
2007-07-28
2007-07-28
No

When ssl is used, after each read data the socket is closed so the related TLD lookups fail. Socket must be reinitialized for every TLD if SSL is used. Otherwise one gets read/write errors to socket after 1st lookup is done.

372a373
>
794a796
>
800,804d801
< # When SSL is used socket is closed after each read
< if (!$this->_socket && 'SSL' == $this->crypt_type) {
< $this->init_socket();
< }
<
805a803
>
850d847
<

While on it, when SSL is used, Crypt/CBC is not required. So you could change the line
require_once 'Crypt/CBC.php';
to
include_once 'Crypt/CBC.php';
(or wrap it inside a if statement where if SSL is used then not require it)

Thanks,
Evren

Discussion

  • HM2K

    HM2K - 2009-11-25

    Please can you provide a patch instead? I don't understand your suggested changes.

    I seen no harm in changing require_once to include_once in this instance.

     
  • Evren Yurtesen

    Evren Yurtesen - 2009-11-25

    I dont quite remember exactly what was the problem anymore :(

    Obviously I provided a diff for the fix I made in 2007 but that might be fixed already... I have nothing more to add (since I dont remember much) so you can close this report if it is not clear.

     

Log in to post a comment.