[Openslp-devel] all patches applied, project version updated

[John C. <joh...@gm...>]

As far as I can tell, I've applied all patches submitted to me at this
point, including the suse patches.  I did not apply the following patches
from suse:

 

1.       03.extensions.diff

2.       11.openslp.truncate.diff

3.       18.openslp.use-TCPDIAG-for-checking-listeners

4.       20.openslp.initda.diff

 

(NOTE: I added the numbers to the front of the patch file names to track the
order in which they were applied to the original openslp 1.2.1 code base.)

 

I didn't apply these patches because they represent significant
modifications to existing functionality or significant enhancements to the
existing OpenSLP specification. The extensions.diff patch contains primarily
the mdns enhancement. I'd like to add mdns support after a little more
investigation into how we might do it more transparently. Since this is a
major addition, I decided not to add it until the next minor 2.x release -
probably 2.1.

 

The truncate.diff patch was not necessary, I felt, because it's purpose is
to ensure that inbound UDP packets are truncated to the max packet size (if
not explicitly allowed by a configuration parameter). The 2.0 code base uses
a calculated maximum transfer unit (mtu) size as the maximum allowable
packet size. Since the max packet size is calculated based on what the wire
will allow, it made little sense to me to check for packets larger than the
largest size allowed by the wire based on a runtime check of that maximum
size.

 

The use-TCPDIAG-for-checking-listeners.diff patch is based on code added by
extensions.diff, so it can't be applied until extensions is applied or at
least until mdns is implemented. When we implement mdns, we should just take
care to incorporate the logic in this patch in our version of mdns.

 

The initda.diff patch also represented a large chunk of new functionality
wherein the slpda comes up and pre-initializes itself to the entire contents
of another existing DA, configured in the properties file. This is a nice
feature also, but should be considered as a significant enhancement to be
added in a future release.

 

Please let me know if I've missed anything. I'm going to stop committing
now, so please grab the latest and build and test on your systems. I've done
some basic testing to ensure it all still pretty much works (at least on
linux), but these patches represent changes, and changes mean possible
errors. If all looks good to everyone in a week or so, we'll release 2.0.

 

Thanks

John