[Openslp-announce] openslp-1.0.8 is a broken build -- patch or download openslp-1.0.8a

[Matt P. <ma...@ca...>]

Ayman,

Thanks for the information.  It has helped me to find a bug that some how 
managed to get into 1.0.8.  I'm not sure if it was a inadvertant cut and 
paste mistake or if it was legitimate.  Regardless, there is a line in 
slpd_incoming.c that should not be there.  I am embarrassed that this slipped 
past validation testing.  OpenSLP 1.0.8 never should have been released with 
line 99 of slpd_incoming.c.

/*-------------------------------------------------------------------------*/
void IncomingDatagramRead(SLPList* socklist, SLPDSocket* sock)
/*-------------------------------------------------------------------------*/
{
    int                 bytesread;
    int                 bytestowrite;
    int                 byteswritten;
    int                 peeraddrlen = sizeof(struct sockaddr_in);

    bytesread = recvfrom(sock->fd,
                         sock->recvbuf->start,
                         SLP_MAX_DATAGRAM_SIZE,
                         0,
                         (struct sockaddr *) &(sock->peeraddr),
                         &peeraddrlen);
    if (bytesread > 0)
    {
        sock->recvbuf->end = sock->recvbuf->start + bytesread;

        switch (SLPDProcessMessage(&sock->peeraddr,
                                   sock->recvbuf,
                                   &(sock->sendbuf)))
        {
        case SLP_ERROR_PARSE_ERROR:
        case SLP_ERROR_VER_NOT_SUPPORTED:
        case SLP_ERROR_MESSAGE_NOT_SUPPORTED:
            sock->state = SOCKET_CLOSE;         <======= Line 99 should not
            break;                                       exist!  
        default:


Anyway, thanks for reporting your problems.  I will make an openslp-1.0.8a 
available immediately.

-- 
Matt Peterson
Sr. Software Engineer
Caldera, Inc
ma...@ca...