Menu ▾ ▴

#160 presence mix_offline_presence parameter

trunk
closed-accepted
Anca Vamanu
modules (179)
5
2010-09-10
2010-09-02
Kennard White
No

Add new module parameter "mix_offline_presence" to presence module. This borrows a subset of the pre-existing "mix_dialog_presence" functionality to create a default PIDF with basic status 'closed' when there are no available presentities.

Discussion

  • Kennard White

    Kennard White - 2010-09-02

    patch file

     
    opensips-pres-mixoffline.patch

  • Anca Vamanu

    Anca Vamanu - 2010-09-03

    Hi Kennard,

    I will review your patch.

    Regards,
    Anca

     

  • Anca Vamanu

    Anca Vamanu - 2010-09-03
    • assigned_to: nobody --> anca_vamanu
     

  • Anca Vamanu

    Anca Vamanu - 2010-09-03

    HI Kennard,

    I agree that this feature is useful and I appreciate that you analyzed the code and discovered that the functionalities added for mix_dialog_presence can very easily be used. I would however change the name of this parameter - maybe in something like 'use_default_closed_body'.

    Regards,
    Anca

     

  • Kennard White

    Kennard White - 2010-09-03

    Hi Anca,

    I don't have preference for what parameter is called. Will you make the module parameter name change when you commit, or would you like me to generate a different patch file?
    Thanks,
    Kennard

     

  • Kennard White

    Kennard White - 2010-09-09

    I integrated with Anca's version in trunk and everything is fine. I didn't do detail verification of the other issue fixed at the same time (too early delete from hash table on expire) but it at least doesn't break anything.

     

  • Anca Vamanu

    Anca Vamanu - 2010-09-10
    • status: open --> closed-accepted
     

  • Anca Vamanu

    Anca Vamanu - 2010-09-10

    Hi Kennard,

    Thank you. I will close this patch report.

    Regards,
    Anca

     

Log in to post a comment.