Menu

#154 modparam support for "str" type

trunk
open-postponed
core (47)
3
2011-06-30
2010-08-16
No

Add new type "STRLEN_PARAM" for modparam that maps to the "str" type of str.h.I don't know where docs for this interface is -- if someone will point me to them (in SVN tree), I'll patch the docs also. Also happy to change the keyword name if someone has better idea.

Discussion

  • Kennard White

    Kennard White - 2010-08-16

    patch file

     
  • Bogdan-Andrei Iancu

    Hi Kennard,

    any module using this new type of params ? the includes only the definition, but no usage :)

    Regards,
    bogdan

     
  • Kennard White

    Kennard White - 2011-01-04

    Hi Bogden,

    See patch 3051083 for example of usage. That particular patch is change to rr module to add flow routing support, and is non-trivial (and my version has now forked substantially from SVN).

    This STRLEN_PARAM patch would allow a lot of code clean up and more robust code in many modules (because the .len parameter is set correctly without manual code). But I haven't made much use of this feature -- doesn't make sense until support is in core, since it makes it impossible module-level patches to be accepted.

     
  • Bogdan-Andrei Iancu

    The set of patches 3040885 , 3042883, 3046433, 3051083 are to be evaluated and integrated for the next release - we need to evaluate the approach in regards to flow routing RFC.

    Regards,
    Bogdan

     
  • Bogdan-Andrei Iancu

    • priority: 5 --> 3
    • assigned_to: nobody --> bogdan_iancu
    • status: open --> open-postponed
     

Log in to post a comment.