Menu ▾ ▴

#255 the second transaction is not linked with the dialog

1.5.x
closed-fixed
Bogdan-Andrei Iancu
modules (454)
5
2010-03-11
2010-01-28
Alexey Popov
No

If we have multiple transactions within one dialog, all of them must be linked to the dialog.
Overwise, reply route can't use dialog flags for the second and all the following transactions.

This situation can be easily reproduced for re-INVITE case

Proposal solution is attached

Thanks,
Alexey

Discussion

  • Alexey Popov

    Alexey Popov - 2010-01-28

    proposal solution that fix this issue

     
    dlg_handlers.c.diff

  • Bogdan-Andrei Iancu

    Bogdan-Andrei Iancu - 2010-02-09

    Hi Alexey,

    indeed the report is correct, but not the fix - you link the dialog to the follow-up transactions without ref counting the dialog (to prevent it to be removed from other places).
    The correct approach is to ref count the dialog (when attached) and to register to the transaction a DESTROY callback to do the unref for the dialog (when the transaction is deleted).

    Let me know if you re-work the patch, otherwise I will do it.

    Regards,
    Bogdan

     

  • Bogdan-Andrei Iancu

    Bogdan-Andrei Iancu - 2010-02-09
    • assigned_to: nobody --> bogdan_iancu
    • status: open --> open-accepted
     

  • Bogdan-Andrei Iancu

    Bogdan-Andrei Iancu - 2010-03-11

    Ok, I did my own fix for this, so to solve all related issues and races - please update from SVN.

    Regards,
    Bogdan

     

  • Bogdan-Andrei Iancu

    Bogdan-Andrei Iancu - 2010-03-11
    • status: open-accepted --> closed-fixed
     

Log in to post a comment.