Menu

#245 infloop due to bad linkedlist traversal

1.6.x
closed-fixed
core (110)
5
2010-01-08
2010-01-08
No

Due to a cause unknown to me, opensips 1.6.0/1 hangs.

Gdb tells me:
0x0808292a <pv_get_hdr+1242>: lea 0x0(%esi),%esi
0x08082930 <pv_get_hdr+1248>: jmp 0x808292a <pv_get_hdr+1242>

1966 /* it is an un-known header -> use name to find it */
1967 for (hf0=hf->next; hf0; hf=hf0->next) {
1968 if (hf0->type==HDR_OTHER_T && hf0->name.len==tv.rs.len

That hf=hf0->next should probably be hf0=hf0->next.

Patch attached.

Regards,
Walter Doekes
OSSO B.V.

Discussion

  • Walter Doekes

    Walter Doekes - 2010-01-08

    pvar linked list traversal fix

     
  • Bogdan-Andrei Iancu

    Hi Walter,

    Thanks for catching this ugly bug/typo....I fixed it on 1.5-1.6 releases and trunk.

    Best regards,
    Bogdan

     
  • Bogdan-Andrei Iancu

    • assigned_to: nobody --> bogdan_iancu
    • status: open --> closed-fixed
     

Log in to post a comment.