Re: [Opensg-core] Merges from fcptr_stable_jun07 to trunk

[Patrick H. <pat...@pr...>]

Dirk Reiners wrote:
> 	Hi Gerrit, hi All,
> 
> Gerrit Voss wrote:
> 
>> looks ok to me, the only very minor comment would be to switch to
>>
>> #ifndef OSG_ENABLE_DOUBLE_MATRIX_STACK
>>      typedef std::pair<UInt32, Matrix>              MatrixStore;
>> #else
>>     typedef std::pair<UInt32, Matrix4d>             DoubleMatrixStore;
>> #endif
>>  
>> in RenderPartition instead of having two MatrixStore / MatrixStack defs.
> 
> If you have two different names, why have an ifndef?

I checked it in this way:

#ifndef OSG_ENABLE_DOUBLE_MATRIX_STACK
     typedef std::pair<UInt32, Matrix>              MatrixStore;
#else
     typedef std::pair<UInt32, Matrix4d>            MatrixStore;
#endif

That allowed the removal of other #ifdef's later in OSGRenderPartition.h.

> In general I like having the double transform, and I think it's great that you 
> wrote it (and we will probably need it in our Army project ;). So I'd love to 
> see it in trunk.
> 
> I'm just not too excited about having it as a compile-time decision, as that 
> either doubles the number of libraries we need to ship or we have to pick one of 
> the two options. I know it's a lot more complicated to make it a runtime choice, 
> so I understand why you did it, I'm just a little uneasy about it.

I too think it would be better as a run-time choice, and Aron may have had 
an idea for how to make it work that way.

> For now I think it makes sense it include it so that it's available, and I don' 
> think there's going to be a problem with the code as is, so please go ahead and 
> commit it to trunk.

Done.

  -Patrick


-- 
Patrick L. Hartling
Senior Software Engineer, Priority 5
http://www.priority5.com/

The information transmitted in this communication is intended only for
the person or entity to which it is addressed and contains proprietary
material. Any review, retransmission, dissemination or other use of, or
taking of any action in reliance upon, this information by persons or
entities other than the intended recipient is prohibited. If you
received this in error, please destroy any copies, contact the sender
and delete the material from any computer.