[Opensc-commits] [OpenSC/OpenSC] 549f24: Prevent in-place modification of verify data

[Simo S. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 549f2479c8137328011e99835513384904b0042d
      https://github.com/OpenSC/OpenSC/commit/549f2479c8137328011e99835513384904b0042d
  Author: Simo Sorce <si...@re...>
  Date:   2026-04-30 (Thu, 30 Apr 2026)

  Changed paths:
    M src/pkcs11/openssl.c

  Log Message:
  -----------
  Prevent in-place modification of verify data

The reverse function previously modified buffers in-place, which
unintentionally altered the caller's input data during GOST R 34.10
verification.

This updates the function to allocate and return a reversed copy instead. It
also simplifies public key parsing by replacing manual byte reversal with
OpenSSL BN_lebin2bn, making the code cleaner and preventing input data
corruption.

Co-authored-by: Gemini <ge...@go...>
Signed-off-by: Simo Sorce <si...@re...>


  Commit: 86c5005b246360f8e0ab1edfac19d568a949bfa1
      https://github.com/OpenSC/OpenSC/commit/86c5005b246360f8e0ab1edfac19d568a949bfa1
  Author: Simo Sorce <si...@re...>
  Date:   2026-04-30 (Thu, 30 Apr 2026)

  Changed paths:
    M src/sm/sm-eac.c

  Log Message:
  -----------
  Replace direct ASN1_STRING field access

Update the terminal authentication code to use ASN1_STRING_get0_data and
ASN1_STRING_length instead of directly reading the data and length fields.
This ensures compatibility with modern OpenSSL versions where these structures
are opaque and must be accessed via their official API to prevent compilation
errors.

Co-authored-by: Gemini <ge...@go...>
Signed-off-by: Simo Sorce <si...@re...>


Compare: https://github.com/OpenSC/OpenSC/compare/7de20377ef5a...86c5005b2463

To unsubscribe from these emails, change your notification settings at https://github.com/OpenSC/OpenSC/settings/notifications