Menu
▾
▴
[Opensc-commits] [OpenSC/OpenSC] 80ea44: authentic: Make coverity happy about bounds
|
From: Jakub J. <no...@gi...> - 2026-04-27 08:12:29
|
Branch: refs/heads/master Home: https://github.com/OpenSC/OpenSC Commit: 80ea44e9fcd01785742dea8df62fecd755be14fd https://github.com/OpenSC/OpenSC/commit/80ea44e9fcd01785742dea8df62fecd755be14fd Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-authentic.c Log Message: ----------- authentic: Make coverity happy about bounds Coverity thinks about this as illegal access, when pin1->len == pin1->pad_length == sizeof(pin_buff) but this would really result only in the memset of 0-length, which should not really access that memory. But this call is technically not needed so lets skip it. CID 503305 Commit: a5f0f407497655e4468c515a7ac37066baabea32 https://github.com/OpenSC/OpenSC/commit/a5f0f407497655e4468c515a7ac37066baabea32 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/pkcs15init/pkcs15-lib.c Log Message: ----------- pkcs15init: Avoid memory leak Thanks coverity CID 503351 Commit: f47791e76d1dc26db94c2857685fea14ab26fff0 https://github.com/OpenSC/OpenSC/commit/f47791e76d1dc26db94c2857685fea14ab26fff0 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-isoApplet.c Log Message: ----------- isoapplet: Avoid possible NULL dereference by moving the NULL check before all uses of the card pointer CID 503459 Commit: fc72a397c4d669fa797eaf95046c27482ce5d130 https://github.com/OpenSC/OpenSC/commit/fc72a397c4d669fa797eaf95046c27482ce5d130 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-rutoken.c Log Message: ----------- rutoken: Remove dead code CID 503460 The file_out is already checked its not NULL before. Commit: 3715c068a6f4a4f9c82b4519cf4587332283d770 https://github.com/OpenSC/OpenSC/commit/3715c068a6f4a4f9c82b4519cf4587332283d770 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-setcos.c Log Message: ----------- setcos: Avoid negative indexing CID 503461 Commit: cf9e46bc2977f5bcd3e7e8a7c7b8ad697bcc0cfd https://github.com/OpenSC/OpenSC/commit/cf9e46bc2977f5bcd3e7e8a7c7b8ad697bcc0cfd Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-myeid.c Log Message: ----------- myeid: Avoid possible NULL pointer dereference by moving the check before using the pointer CID 503462 Commit: 3ad3d13730f6d72917c4f1d6fee9ae95fe9c2584 https://github.com/OpenSC/OpenSC/commit/3ad3d13730f6d72917c4f1d6fee9ae95fe9c2584 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-entersafe.c Log Message: ----------- entersafe: Fis possible NULL pointer dereference by moving the check before dereferencing the pointer CID 503463 Commit: b14ea2f85b8bd421357293a7387b53490850aa16 https://github.com/OpenSC/OpenSC/commit/b14ea2f85b8bd421357293a7387b53490850aa16 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-cardos.c Log Message: ----------- cardos: Avoid NULL dereference by moving the check before using the pointer CID 503464 Commit: 3a5b551fc2f76e6330a0998249b781fa1ddb3115 https://github.com/OpenSC/OpenSC/commit/3a5b551fc2f76e6330a0998249b781fa1ddb3115 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-belpic.c Log Message: ----------- belpic: Avoid NULL dereference by moving the ckeck before using the pointer CID 503465, CID 503466 Commit: 5919be38397d22dd4ee4748ee95d40bfe9c9680e https://github.com/OpenSC/OpenSC/commit/5919be38397d22dd4ee4748ee95d40bfe9c9680e Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-entersafe.c Log Message: ----------- entersafe: Avoid NULL dereference by moving the check before using the pointer CID 503467 Commit: 607aa2a1ab1827bd22b8d40f029302a4a46f58cb https://github.com/OpenSC/OpenSC/commit/607aa2a1ab1827bd22b8d40f029302a4a46f58cb Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-coolkey.c Log Message: ----------- coolkey: Avoid NULL deference by moving the check after using the pointer CID 503468 Commit: 679a9873fc426299c4cb23fc2160c99c6e6c558a https://github.com/OpenSC/OpenSC/commit/679a9873fc426299c4cb23fc2160c99c6e6c558a Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-entersafe.c Log Message: ----------- entersafe: Avoid NULL dereference by moving the check before using the pointer CID 503469 Commit: 554beb4b6d9864a35b2ddd9d6ab5854a97e26085 https://github.com/OpenSC/OpenSC/commit/554beb4b6d9864a35b2ddd9d6ab5854a97e26085 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/pkcs15init/pkcs15-rtecp.c Log Message: ----------- rtecp: Avoid memory leak on error CID 503470 Commit: a6a311a1df4d7dfb23035c99fb1f6b61db976de2 https://github.com/OpenSC/OpenSC/commit/a6a311a1df4d7dfb23035c99fb1f6b61db976de2 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-cac.c M src/libopensc/card-cac1.c Log Message: ----------- cac: Avoid NULL dereference by moving the NULL check before the pointer usage CID 503471 Commit: 7e0c63c0bad28aafae67117cb895e5249a3abb1c https://github.com/OpenSC/OpenSC/commit/7e0c63c0bad28aafae67117cb895e5249a3abb1c Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/pkcs15init/pkcs15-rtecp.c Log Message: ----------- rtecp: Remove dead code CID 503472 Commit: e7fbecbe5ec261d39fb35eaf76ef05cfde4f8061 https://github.com/OpenSC/OpenSC/commit/e7fbecbe5ec261d39fb35eaf76ef05cfde4f8061 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- openpgp: Avoid invalid integer handling Fixes-up a807d69706ee6d88f7e57f4b455e5631f331d5a1, which made the set_taglength_tlv() return negative value, which was not expected by the caller. CID 503473 Commit: 7e0a2c0f40f1f00084738077e4942deb917bea58 https://github.com/OpenSC/OpenSC/commit/7e0a2c0f40f1f00084738077e4942deb917bea58 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-entersafe.c Log Message: ----------- entersafe: Fix NULL dereference by moving the check before pointer use CID 503474 Commit: bb62549a7d8de7b51bdcf6c63e3ac70df48f62dd https://github.com/OpenSC/OpenSC/commit/bb62549a7d8de7b51bdcf6c63e3ac70df48f62dd Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-oberthur.c Log Message: ----------- oberthur: Fix NULL dereference CID 503475 Commit: cf1c82bdc0ecfc0bcc12d22e2aa69bdff8d8ef77 https://github.com/OpenSC/OpenSC/commit/cf1c82bdc0ecfc0bcc12d22e2aa69bdff8d8ef77 Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/pkcs15init/pkcs15-rtecp.c Log Message: ----------- rtecp: Remove dead code the variable was already checked for NULL before CID 503476 Commit: 5c6f4b831ab29a9d754d7f8a65d4dc2d4d4d742c https://github.com/OpenSC/OpenSC/commit/5c6f4b831ab29a9d754d7f8a65d4dc2d4d4d742c Author: Jakub Jelen <jj...@re...> Date: 2026-04-27 (Mon, 27 Apr 2026) Changed paths: M src/libopensc/card-piv.c Log Message: ----------- piv: Fix Off-by-one comparison Introduced in previous commit rewriting asserts (a807d69706ee6d88f7e57f4b455e5631f331d5a1) CID 503477 Compare: https://github.com/OpenSC/OpenSC/compare/6a8b1b65714e...5c6f4b831ab2 To unsubscribe from these emails, change your notification settings at https://github.com/OpenSC/OpenSC/settings/notifications |
