#960 Activation/Deact units didnot allow amf node dn in single step upgrade.

[Hrishikesh]

Setup :SLES 64bit, changeset: 5270 of opensaf-4.3.x branch.

Problem description:

During singlestep upgrade, under activation/deact units is not handling AMF node DN.
if given it throws an error saying DN should be of type SU or COMP,log snippet
given below
=====
ER SmfUpgradeProcedure::getNodeForCompSu:The DN does not refere to a SaAmfSUT or SaAmfComp class, DN=safAmfNode=PL-3,safAmfCluster=myAmfCluster
=====

If it is a constraint not allowing Amf Node, please capture it in some documentation.

Snippets of campaign xml and log

<forAddRemove>
<deactivationUnit>
<actedOn>
<byName objectDN="safAmfNode=PL-3,safAmfCluster=myAmfCluster"></byName>
<byName objectDN="safSu=dummy_NWay_1Norm_1,safSg=SG_dummy_n,safApp=N"></byName>
=============

=================
Jul 15 15:21:24 SLES1 osafsmfd[11544]: NO PROC: Start upgrade procedure safSmfProc=amfClusterProc-1
Jul 15 15:21:24 SLES1 osafsmfd[11544]: NO PROC: Start procedure init actions
Jul 15 15:21:24 SLES1 osafsmfd[11544]: ER SmfUpgradeProcedure::getNodeForCompSu:The DN does not refere to a SaAmfSUT or SaAmfComp class, DN=safAmfNode=PL-3,safAmfCluster=myAmfCluster
Jul 15 15:21:24 SLES1 osafsmfd[11544]: NO PROC: Procedure init actions completed
Jul 15 15:21:24 SLES1 osafsmfd[11544]: NO PROC: Start executing the steps
Jul 15 15:21:24 SLES1 osafsmfd[11544]: NO STEP: Executing AU lock step safSmfStep=1,safSmfProc=amfClusterProc-1,safSmfCampaign=campaign,safApp=safSmfService
Jul 15 15:21:24 SLES1 osafsmfd[11544]: NO STEP: Online installation of new software
==================

[Robert Apanowicz]

The problem exists in 4.7.
The error printout in 4.7 does not exist anymore, since the implementation of SmfUpgradeProcedure changed between 4.3 and 4.7.

Test results soo far in 4.7:

-"forModify": works
-"forAddRemove": seems to work when the deact/act are in the same procedure:

<upgradeScope>
<forAddRemove>
<deactivationUnit>
<actedOn>
<byName objectDN="safAmfNode=SC-1,safAmfCluster=myAmfCluster"/>
<byName objectDN="safAmfNode=SC-2,safAmfCluster=myAmfCluster"/>
</actedOn>
<swRemove bundleDN="safSmfBundle=7.7.7" pathnamePrefix="/opt/amf_demo"/>
</deactivationUnit>
<activationUnit>
<actedOn>
<byName objectDN="safAmfNode=SC-1,safAmfCluster=myAmfCluster"/>
<byName objectDN="safAmfNode=SC-2,safAmfCluster=myAmfCluster"/>
</actedOn>
<swAdd bundleDN="safSmfBundle=9.9.9" pathnamePrefix="/opt/amf_demo"/>
</activationUnit>
</forAddRemove>
</upgradeScope>

-"forAddRemove": when deact/act are in 2 separate procedures:

Apr 29 07:24:58 SC-1 osafsmfd[514]: NO SmfUpgradeProcedure::createImmStep: No node given for bundle safSmfBundle=7.7.7
Apr 29 07:24:58 SC-1 osafsmfd[514]: NO SmfUpgradeProcedure::createImmSteps: creation of SaSmfStep object structure fails, rc=SA_AIS_ERR_NOT_EXIST (12)
Apr 29 07:24:58 SC-1 osafsmfd[514]: NO SmfProcStateInitial::executeInit:createImmSteps in IMM failes
Apr 29 07:24:58 SC-1 osafsmfd[514]: NO CAMP: Procedure safSmfProc=SingleStepCompForAddRemoveByName_nodeUnlock returned FAILED

In "SmfUpgradeProcedure::calculateSingleStep" at activate case the "nodeList" is not populated with nodes, because no node found.
(and later: no swNodes added to the created step object using "addSwNodes")

Node(s) found in deact case since it uses the method "getActDeactUnitsAndNodes" to get the node.
Node(s) not found in act case since it uses the method "getNodeForCompSu" to get the node, and in that case the input DN must be:
if ((i_objectDn == (objit).second.suDN) || (i_objectDn == (objit).second.compDN)) {
return (*objit).second.nodeDN;
}
which will never happen if dn object is an SaAmfNode instance.

Next step of the investigation could be to check if
the above campaign part is valid at all (both cases when deact/act are in same or in separate procedures).

[Zoran Milinkovic]

Change status for Rafael until he gets rights to do changes in SourceForge.

https://sourceforge.net/p/opensaf/mailman/message/34128863/

[Ingvar Bergström]

changeset: 6589:d719ade2b028
tag: tip
parent: 6586:86155b31d535
user: Rafael Odzakow rafael.odzakow@ericsson.com
date: Mon May 18 10:27:25 2015 +0200
summary: smfd: get nodes for activation without warning if entity was a node [#960]

changeset: 6588:21730a950421
branch: opensaf-4.6.x
parent: 6585:751c407456d0
user: Rafael Odzakow rafael.odzakow@ericsson.com
date: Mon May 18 10:27:25 2015 +0200
summary: smfd: get nodes for activation without warning if entity was a node [#960]

changeset: 6587:071c4ca7a679
branch: opensaf-4.5.x
parent: 6584:1c592917282b
user: Rafael Odzakow rafael.odzakow@ericsson.com
date: Mon May 18 10:27:25 2015 +0200
summary: smfd: get nodes for activation without warning if entity was a node [#960]