Menu

#883 osaf: Build fails with GCC 4.9.0

4.3.3
fixed
None
defect
osaf
-
4.3.2
minor
2014-05-09
2014-05-05
No

OpenSAF fails to build with GCC 4.9.0, due to a new compiler warning. In one of the files, this warning actually detected a bug in the OpenSAF source code, as can be seen below:

In file included from ncs_sprr.c:37:0:
ncs_sprr.c: In function 'ncs_splr_api':
../../../../osaf/libs/core/include/ncssysf_def.h:105:54: error: right-hand operand of comma expression has no effect [-Werror=unused-value]
 #define m_LEAP_DBG_SINK(r) (TRACE("IN LEAP_DBG_SINK"), r)
                                                      ^
ncs_sprr.c:46:58: note: in expansion of macro 'm_LEAP_DBG_SINK'
 #define m_NCS_SPRR_DBG_SINK(x,y)  printf("SPRR:%s\n", y),m_LEAP_DBG_SINK(x)
                                                          ^
ncs_sprr.c:237:9: note: in expansion of macro 'm_NCS_SPRR_DBG_SINK'
    rc = m_NCS_SPRR_DBG_SINK(NCSCC_RC_DUPLICATE_ENTRY, "SPLR duplication attempted");

Related

Tickets: #883
Wiki: ChangeLog-4.3.3
Wiki: ChangeLog-4.4.1

Discussion

  • Anders Widell

    Anders Widell - 2014-05-08
    • status: accepted --> review
     
  • Anders Widell

    Anders Widell - 2014-05-09
    • status: review --> fixed
     

Log in to post a comment.