#768 Issues in invalid return values for AMF API's in different scenarios.

[manu]

1 .call saAmfComponentErrorReport_4 with negative error detection time
Got return value : SA_AIS_OK, expected return value : INVALID_PARAM

1. call saAmfComponentErrorReport_4 with non existent entity
   Got return value : SA_AIS_ERR_BAD_OPERATION, expected return value : NOT_EXIST

2. call saAmfComponentErrorCLear_4 on operationally enabled component
   Got return value : SA_AIS_OK, expected value : SA_AIS_ERR_NO_OP

3. When saAmfResponse_4 is called continuously two times with proper params in proper callback, ERR_NOT_EXIST is not returned for the second time. Instead SA_AIS_OK is returned

4. When saAmfResponse_4 is called with invalid invocation, the return value is ERR_INVALID_PARAM, and the expected value is ERR_NOT_EXIST

5. Finalized handle for api's ErrorReport_4,ErrorClear_4 and PmStart_3 returns ERR_VERSION instead of BAD_HANDLE

6. saAmfResponse_4 returns SA_AIS_ERR_INVALID_PARAM, if the error is set to values other than SA_AIS_OK, SA_AIS_FAILED_OPERATION and SA_AIS_ERR_NOT_READY.
   According to page 296, last para
   Any other error code set in the error parameter in the response will be treated by
   the Availability Management Framework as if the caller had set the error parameter
   to SA_AIS_ERR_FAILED_OPERATION

[Nagendra Kumar]

Duplicate of https://sourceforge.net/p/opensaf/tickets/738/

[Sirisha Alla]

adding few more cases of spec validations for conformance:

1) when saAmfComponentErrorReport_4 is invoked with SaAmfReadinessImpactT value out of enum definitions INVALID_PARAM is expected but as of now returns ERR_NOT_SUPPORTED
2) DN validation is not being done by amf. When saAmfComponentErrorReport_4 is invoked with malformed DN for example: safComp=AmfDemo5,safSg=AmfDemo,safApp=AmfDemo, api returns BAD_OPERATION instead of not supported.
3) When saAmfComponentErrorReport_4 is invoked with proper DN with non existing component name, api returns BAD_OPERATION instead of ERR_NOT_EXIST

[Nagendra Kumar]

As part of ticket cleanup, evaluated and decided to keep it as enhancement.