This a really bad example of using C macros! Instead of having a bit field manipulated with macros the object should have a bool member. Any problem would show up at compile time. Now it was caught in runtime after years...
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
changeset: 4808:2fc6a6d4c09d
branch: opensaf-4.3.x
parent: 4805:c9244d28be22
user: Nagendra Kumarnagendra.k@oracle.com
date: Mon Jan 13 15:44:16 2014 +0530
summary: amfnd: Correct the check for su [#717]
changeset: 4809:ae8b6aa49caa
branch: opensaf-4.2.x
tag: tip
parent: 4801:4d39fbf0a656
user: Nagendra Kumarnagendra.k@oracle.com
date: Mon Jan 13 15:44:37 2014 +0530
summary: amfnd: Correct the check for su [#717]
[staging:2fc6a6]
[staging:ae8b6a]
Related
Tickets:
#717This a really bad example of using C macros! Instead of having a bit field manipulated with macros the object should have a bool member. Any problem would show up at compile time. Now it was caught in runtime after years...