#582 AMF: SU cannot be locked in shutting-down admin state

[Hans Feldt]

There is logic to handle the case where an SU gets locked while it is shutting-down state. However a recently () added check in su_admin_op_cb() makes this code unreachable. The change in question was:

changeset: 4251:3ea7a5ddde48
parent: 4248:a3cb80b7e1b9
user: Nagendra Kumarnagendra.k@oracle.com
date: Mon May 06 15:18:55 2013 +0530
summary: Amf: Add validation during Sg and Su admin operation (#3117)

So it seemed to have worked before this change. Locking as SI works while in shutting-down state.

I think the changeset above should be corrected to exclude the current SU under operation.

[Nagendra Kumar]

Admin operations are allowed sequentially in Amf since begening.

[Nagendra Kumar]

Can we get some view point otherwise we will close it.

[Hans Feldt]

"we will close it"...
I as maintainer wrote the ticket. There is nothing wrong with it as far as I understand. What used to work no longer works. Just un-assign yourself from it

[Nagendra Kumar]

I will close by documenting it.

[Nagendra Kumar]

I have checked the previous changeset 4248 and lock operation after shutdown operation is not working. It logs as below:

Jul 31 15:16:42 PM_SC-180 osafamfd[26448]: WA Admin operation is already going

I will try to fix it also.

[Nagendra Kumar]

If lock is issued on su after shutdown, Amf will respond shutdown first and then after completion of lock, it will respond to imm.

[Nagendra Kumar]

changeset: 5561:0cd4463419ab
tag: tip
user: Nagendra Kumarnagendra.k@oracle.com
date: Tue Aug 12 20:39:12 2014 +0530
summary: amfd: allow lock on su after issue of shutdown [#582]

[staging:0cd446]

[Nagendra Kumar]

changeset: 5624:d6bded84da41
branch: opensaf-4.3.x
parent: 5622:91cc3199615f
user: Nagendra Kumarnagendra.k@oracle.com
date: Wed Aug 20 16:27:34 2014 +0530
summary: amfd: allow lock on su after issue of shutdown [#582]

changeset: 5625:acd24a430677
branch: opensaf-4.4.x
tag: tip
parent: 5623:b0fd1a2c4b8a
user: Nagendra Kumarnagendra.k@oracle.com
date: Wed Aug 20 16:28:10 2014 +0530
summary: amfd: allow lock on su after issue of shutdown [#582]

[staging:d6bded]
[staging:acd24a]