#474 AMF: Comp Failover performed before comp cleanup done

[Hans Feldt]

AMF performs failover before the faulty component is in presence state UNINSTANTIATED.

The #98 patch series fixes the problem for SU Failover but not for Comp failover. This needs to be fixed in all branches.

The problem starts in avnd_err_rcvr_su_failover() where two things are initiated by the same error event: 1) send AVSV_N2D_OPERATION_STATE_MSG and 2) cleanup component

This causes parallelism and potentially inconsistencies and problems for AMF applications.

[Hans Feldt]

For some reason (I don't understand), an error detected for NPI component does not cause cleanup to be executed. See avnd_err_rcvr_su_failover():

    /* clean the failed comp */
    if (m_AVND_SU_IS_PREINSTANTIABLE(su)) {
            rc = avnd_comp_clc_fsm_run(cb, failed_comp, AVND_COMP_CLC_PRES_FSM_EV_CLEANUP);
            if (NCSCC_RC_SUCCESS != rc)
                    goto done;
    }

will be removed unless someone justifies why it is there!

[Nagendra Kumar]

changeset: 4401:8e587f3ddee5
branch: opensaf-4.2.x
parent: 4398:af229a3d4313
user: Hans Feldthans.feldt@ericsson.com
date: Fri Aug 02 15:51:45 2013 +0530
summary: amfnd: report failover after comp cleanup [#474]

changeset: 4402:d4a748f81542
branch: opensaf-4.3.x
tag: tip
parent: 4399:a7415903218d
user: Hans Feldthans.feldt@ericsson.com
date: Fri Aug 02 15:52:46 2013 +0530
summary: amfnd: report failover after comp cleanup [#474]