#448 LOG: Incorrect validity checks in IMM Oi when creating and modifying configuration streams

[elunlen]

Validity check when changing saLogStreamFileName via IMM adm interace is incorrect. Will always return information saying that the file name does not already exists. The content of attribute saLogStreamFileName is used for checking not a complete path to any file.
See file lgs_imm.c function check_attr_validity(..)
There are more problems with the validity check. See comments below and related ticket [#771]

[elunlen]

• Description has changed:

Diff:

--- old
+++ new
@@ -1,2 +1,2 @@
-Validity check when changing saLogStreamFileName via IMM adm interace is incorrect. Will always return information saying that the file name does not already exists.
+Validity check when changing saLogStreamFileName via IMM adm interace is incorrect. Will always return information saying that the file name does not already exists. The content of attribute saLogStreamFileName is used for checking not a complete path to any file.
 See file lgs_imm.c function check_attr_validity(..)

[elunlen]

A possible solution is to construct a path to the <name>.cfg file using "root path" + "relative path" + "file name" + ".cfg"
example: "repl_opensaf/saflog" + "/./" + "saLogAlarm" + ".cfg"

[elunlen]

There are more problems with the validity check:
- File name and relative path shall be checked against other existing streams.
The path + file name must not already exist
- fixedLogRecordSize, maxLogFileSize and maxLogRecordSize are related and must be checked
against each-other.

[elunlen]

A description of the current validation and a suggestion of how to change it can be found in the attached StreamCfg.pdf document.
Note1:
Note that saLogStreamPathName cannot be changed in runtime but a validation is needed when a new application configuration stream object is created.

Note2:
When reading and commenting on this please consider if any of the suggested changes in validation may compromise backwards compatibility

[elunlen]

changeset: 5661:57435ac5772b
tag: tip
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 13:43:42 2014 +0200
summary: log: Add new tests for validation of attributes at create/modify stream conf obj [#448]

rev: 57435ac5772bdb4f7bd84ad94351eb0f18b0e8a3

changeset: 5660:64e05f496c67
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 13:40:53 2014 +0200
summary: log: Fix incorrect test cases in current test suite [#448]

rev: 64e05f496c6789058137777541931e885c6cc26b

changeset: 5659:f3b7ff1bb2a3
parent: 5649:977296dc67c0
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 13:40:35 2014 +0200
summary: log: Fix validity check for IMM create/modify stream [#448]

rev: f3b7ff1bb2a3bc2c7d587844e23b61e196024a0d

changeset: 5658:85d70029359a
branch: opensaf-4.5.x
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 13:43:42 2014 +0200
summary: log: Add new tests for validation of attributes at create/modify stream conf obj [#448]

rev: 85d70029359afb03e8efd570e9f59def0405ffcf

changeset: 5657:f406b1cc97da
branch: opensaf-4.5.x
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 13:40:53 2014 +0200
summary: log: Fix incorrect test cases in current test suite [#448]

rev: f406b1cc97da9dfaafdd0e9a69c31e5da3af9c34

changeset: 5656:5c869d98ba95
branch: opensaf-4.5.x
parent: 5648:bc8d57d94f9f
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 13:40:35 2014 +0200
summary: log: Fix validity check for IMM create/modify stream [#448]

rev: 5c869d98ba950fa093c153423366cb6ee3af262a

changeset: 5655:eb9e5672321d
branch: opensaf-4.4.x
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 13:41:16 2014 +0200
summary: log: Add new tests for validation of attributes at create/modify stream conf obj [#448]

rev: eb9e5672321d127624aef30b8ac97a573772600e

changeset: 5654:3ff0e830e5ae
branch: opensaf-4.4.x
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 13:40:53 2014 +0200
summary: log: Fix incorrect test cases in current test suite [#448]

rev: 3ff0e830e5ae3b447a4cf3681200c984877bb17e

changeset: 5653:4612723ae05d
branch: opensaf-4.4.x
parent: 5643:1930e5124320
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 13:40:35 2014 +0200
summary: log: Fix validity check for IMM create/modify stream [#448]

rev: 4612723ae05d5001f10bf9d10f3c03a50203f675

changeset: 5652:4d5464122620
branch: opensaf-4.3.x
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 12:57:08 2014 +0200
summary: log: Add new tests for validation of attributes at create/modify stream conf obj [#448]

rev: 4d546412262087b65ad73116c090e58ff5918b49

changeset: 5651:7170a1e2cd7f
branch: opensaf-4.3.x
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 12:56:53 2014 +0200
summary: log: Fix incorrect test cases in current test suite [#448]

rev: 7170a1e2cd7f95ed680fcc430ca19f7083379383

changeset: 5650:6ff6f78165e2
branch: opensaf-4.3.x
parent: 5641:5156cb917641
user: Lennart Lund lennart.lund@ericsson.com
date: Mon Aug 25 12:56:25 2014 +0200
summary: log: Fix validity check for IMM create/modify stream [#448]

rev: 6ff6f78165e26634b9abed45b93ff32d1559c309