#310 osafamfnd crashes for various bad input

[Nagendra Kumar]

Migrated from http://devel.opensaf.org/ticket/3020

amfnd needs to be hardened for bad input for obvious security reasons. List of issues found so far:

• avnd_mds_dec/avnd_mds_flat_dec: osafassert in case default
• avnd_mds_flat_ava_dec: seg fault since msg size not checked
• avnd_mds_rcv: osafassert in case default
• avnd_evt_destroy: osafassert in case default

[Hans Feldt]

related to https://sourceforge.net/p/opensaf/tickets/83/

[Hans Feldt]

[opensaf-4.2.x:4440]
[opensaf-4.3.x:4441]
[default:4442]

[Hans Feldt]

[default:92a727b73152]
hg tip --template '[{branch}:{node|short}]\n'

[Hans Feldt]

[default:92a727]
testing...

[Hans Feldt]

[92a727]
[staging:92a727]
again...

[Hans Feldt]

[staging:e20628]
[staging:a703bd]
[staging:92a727]

[Hans Feldt]

Developers please exec the following command before push and paste the output into the ticket:

$ changes=$(hg outg --template '{node}\n' | egrep -v comparing|searching | cut -c -6); for c in $changes; do echo "[staging:$c]"; done

This will create hyperlinks between the artifact (ticket) and the mercurial repository.

We need to come up with some mercurial pre push hook that does this automatically.

[Anders Bjornerstedt]

This information needs to go int tools/devel/review.
Perhaps the commit.template whatever that is.

Just having it an old mail is a bit too loose.

/AndersBj

---

From: Hans Feldt [mailto:hansfeldt@users.sf.net]
Sent: den 28 augusti 2013 09:44
To: [opensaf:tickets]
Subject: [tickets] [opensaf:tickets] #310 osafamfnd crashes for various bad input

Developers please exec the following command before push and paste the output into the ticket:

$ changes=$(hg outg --template '{node}\n' | egrep -v comparing|searching | cut -c -6); for c in $changes; do echo "[staging:$c]"; done

This will create hyperlinks between the artifact (ticket) and the mercurial repository.

We need to come up with some mercurial pre push hook that does this automatically.

---

[tickets:#310]http://sourceforge.net/p/opensaf/tickets/310/ osafamfnd crashes for various bad input

Status: fixed
Created: Fri May 24, 2013 08:25 AM UTC by Nagendra Kumar
Last Updated: Wed Aug 28, 2013 07:35 AM UTC
Owner: nobody

Migrated from http://devel.opensaf.org/ticket/3020

amfnd needs to be hardened for bad input for obvious security reasons. List of issues found so far:

• avnd_mds_dec/avnd_mds_flat_dec: osafassert in case default
• avnd_mds_flat_ava_dec: seg fault since msg size not checked
• avnd_mds_rcv: osafassert in case default
• avnd_evt_destroy: osafassert in case default

---

Sent from sourceforge.net because opensaf-tickets@lists.sourceforge.net is subscribed to https://sourceforge.net/p/opensaf/tickets/

To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/opensaf/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.

[Hans Feldt]

changeset: 4482:d438818ec520
branch: opensaf-4.2.x
parent: 4479:06e93118623b
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Sep 09 11:46:10 2013 +0200
summary: avnd: fix print of sizeof [#310]

changeset: 4483:99c7d914f617
branch: opensaf-4.3.x
parent: 4480:d0bbe0f71f4f
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Sep 09 11:46:10 2013 +0200
summary: avnd: fix print of sizeof [#310]

changeset: 4484:941525099ef6
tag: tip
parent: 4481:99e677e58ac5
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Sep 09 11:52:00 2013 +0200
summary: amfnd: fix print of sizeof [#310]

[staging:d43881]
[staging:99c7d9]
[staging:941525]

32 still does not build on 4.2 (at least)