#2980 amfd: Unnessessary start clm track in every 2N application failover

[Minh Hon Chau]

Currently if a 2N SU hosted in a SC, and the active assignment is failed over to it, amfd calls clm_track_start. This happens for all kinds of 2N SG. If the clm track start failed randomly with TRY_AGAIN for all 2N applications, amfd queue up all clm track start jobs, this delays the other jobs to update to IMM and NTF.

Amfd should start clm tracking for 2N Opensaf only in failover.

uint32_t SG_2N::susi_success_sg_realign
...

  if ((state == SA_AMF_HA_ACTIVE) &&
      (cb->node_id_avd == su->su_on_node->node_info.nodeId)) {
    /* This is as a result of failover, start CLM tracking*/
    if (avd_clm_track_start(cb) == SA_AIS_ERR_TRY_AGAIN)
      Fifo::queue(new ClmTrackStart());
  }

...

[Minh Hon Chau]

commit 9ce04bcf9858c8a48a57cd8edff482a5b1d7bc4f
Author: Minh Chau minh.chau@dektech.com.au
Date: Thu Dec 13 09:29:46 2018 +1100

amfd: Only start clm track for 2N Opensaf SU in failover [#2980]