#2960 amfd: Instantiated SU remains OUT_OF_SERVICE after the node completes to join the cluster

[Minh Hon Chau]

This problem is similar to #2916, in which the admin unlock-in/unlock SU are initiated before cluster startup finishes. The difference is that, after the cluster startup finishes, the node completes to join the cluster, the Opensaf SUs are assigned, AMF walks through all SGs in avd_sg_app_node_su_inst_func() to pick up the uninstantiated SU to start instantiation. In this case, because the SU is instantiated, so AMF skips this SU avd_sg_app_node_su_inst_func().

Some outlined logs,

<143>1 2018-10-24T23:39:16.642207+02:00 SC-1 osafamfd 10728 osafamfd [meta sequenceId="54490"] 10728:amf/amfd/su.cc:935 >> unlock: 'safSu=SC-2,safSg=NWA,safApp=ABC-DEF-Amfproxy'
<143>1 2018-10-24T23:39:16.642223+02:00 SC-1 osafamfd 10728 osafamfd [meta sequenceId="54491"] 10728:amf/amfd/su.cc:918 >> set_admin_state: 'safSu=SC-2,safSg=NWA,safApp=ABC-DEF-Amfproxy' LOCKED => UNLOCKED

<143>1 2018-10-24T23:39:23.771978+02:00 SC-1 osafamfd 10728 osafamfd [meta sequenceId="56132"] 10728:amf/amfd/cluster.cc:55 >> avd_cluster_tmr_init_evh

<143>1 2018-10-24T23:39:23.833418+02:00 SC-1 osafamfd 10728 osafamfd [meta sequenceId="57914"] 10728:amf/amfd/sg_nwayact_fsm.cc:1316 >> realign: 'safSg=NWA,safApp=ABC-DEF-Amfproxy'
<143>1 2018-10-24T23:39:23.833566+02:00 SC-1 osafamfd 10728 osafamfd [meta sequenceId="57920"] 10728:amf/amfd/sgproc.cc:111 >> avd_new_assgn_susi: 'safSu=SC-1,safSg=NWA,safApp=ABC-DEF-Amfproxy' 'safSi=xyz.main-NWA-1,safApp=ABC-DEF-Amfproxy' state=1

<143>1 2018-10-24T23:39:25.459023+02:00 SC-1 osafamfd 10728 osafamfd [meta sequenceId="66073"] 10728:amf/amfd/ndfsm.cc:622 >> avd_nd_ncs_su_assigned
<143>1 2018-10-24T23:39:25.459034+02:00 SC-1 osafamfd 10728 osafamfd [meta sequenceId="66074"] 10728:amf/amfd/node.cc:461 >> avd_node_state_set: 'safAmfNode=SC-2,safAmfCluster=myAmfCluster' NCS_INIT => PRESENT
<143>1 2018-10-24T23:39:25.493787+02:00 SC-1 osafamfd 10728 osafamfd [meta sequenceId="67179"] 10728:amf/amfd/sgproc.cc:1806 >> avd_sg_app_node_su_inst_func: 'safAmfNode=SC-2,safAmfCluster=myAmfCluster'

[Minh Hon Chau]

commit 7c5d4b3f02b425e9a96665b5b862c9daa321230a
Author: Minh Chau minh.chau@dektech.com.au
Date: Thu Nov 15 22:10:15 2018 +1100

amfd: Give assignment for pre-instantiated su after the node joins cluster [#2960]