Menu

#2943 imm: coredump is generated during roaming test

5.19.01
fixed
None
defect
imm
d
major
False
2019-01-09
2018-10-23
No

I missed handling the roaming SC case in the ticket [#2934] . Instead of going to accept_node directly, it should go to update_node_type. With roaming, IMMND veteran could run on system controller node type.

diff --git a/src/imm/immd/immd_evt.c b/src/imm/immd/immd_evt.c
index 9cd82da64..a0f632b7e 100644
— a/src/imm/immd/immd_evt.c
+++ b/src/imm/immd/immd_evt.c
@@ -1814,7 +1814,7 @@ static uint32_t immd_evt_proc_immnd_intro(IMMD_CB cb, IMMD_EVT evt,
cb->ccb_id_count, msg->ccb_id_count,
cb->impl_count, msg->impl_count);
}
- goto accept_node;
+ goto update_node_type;
}
if (cb->fevsSendCount < evt->info.ctrl_msg.fevs_count)
{ @@ -1887,6 +1887,7 @@ static uint32_t immd_evt_proc_immnd_intro(IMMD_CB cb, IMMD_EVT evt, }
}
+update_node_type:
/ Determine type of node. /
if (sinfo->dest == cb->loc_immnd_dest) {
node_info->isOnController = true;

1 Attachments

Related

Tickets: #2934
Wiki: ChangeLog-5.19.01

Discussion

  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-10-23
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,4 +1,4 @@
    -I missed handling the roaming SC case in the ticket [#2934] . Instead of going to `accept_node` directly, it should go to `update_node_type`. With roaming, veteran could be system controller node type.
    +I missed handling the roaming SC case in the ticket [#2934] . Instead of going to `accept_node` directly, it should go to `update_node_type`. With roaming, IMMND veteran could run on system controller node type.
    
     diff --git a/src/imm/immd/immd_evt.c b/src/imm/immd/immd_evt.c
     index 9cd82da64..a0f632b7e 100644
    
     

    Related

    Tickets: #2934

  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-10-23
    • status: assigned --> review
     
  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-11-05
    • status: review --> fixed
     
  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-11-05

    commit f8a6848a1cdbff0b518c3db951e4689e260226c7 (HEAD -> develop, origin/develop, ticket-2943)
    Author: Vu Minh Nguyen vu.m.nguyen@dektech.com.au
    Date: Mon Nov 5 11:29:12 2018 +0700

    imm: fix coredump generated during roaming test [#2943]
    
    The fix of ticket [#2934] was not covered the roaming SC case.
    With roaming, IMMND veteran could run on system controller node type.
    
    Instead of going to accept_node directly in previous fix, it should go to
    update_node_type.
    
     

Log in to post a comment.