Menu

#2752 log: not reject creating log streams with same file name in same CCB

5.18.04
fixed
nobody
None
defect
log
d
major
False
2018-02-07
2017-12-28
No
$ immcfg 
> immcfg -c SaLogStreamConfig safLgStrCfg=test3 -a saLogStreamPathName=. -a saLogRecordDestination=test -a saLogStreamFileName=test3
> immcfg -c SaLogStreamConfig safLgStrCfg=test4 -a saLogStreamPathName=. -a saLogRecordDestination=test -a saLogStreamFileName=test3
> $
$ immlist safLgStrCfg=test3
Name                                               Type         Value(s)
========================================================================
safLgStrCfg                                        SA_STRING_T  safLgStrCfg=test3 
saLogStreamPathName                                SA_STRING_T  . 
saLogStreamFileName                                SA_STRING_T  test3 

$ immlist safLgStrCfg=test4
Name                                               Type         Value(s)
========================================================================
safLgStrCfg                                        SA_STRING_T  safLgStrCfg=test4 
saLogStreamPathName                                SA_STRING_T  . 
saLogStreamFileName                                SA_STRING_T  test3 

LOG server should not allow creating streams which have the same target log file, or that target exists.

Related

Wiki: ChangeLog-5.18.04

Discussion

  • Vu Minh Nguyen

    Vu Minh Nguyen - 2017-12-29
    • summary: log: able to create log streams with same file name in same CCB --> log: not reject creating log streams with same file name in same CCB
     
  • Canh Truong

    Canh Truong - 2017-12-29
    • status: unassigned --> assigned
    • assigned_to: Canh Truong
     
  • Canh Truong

    Canh Truong - 2018-01-03

    In case 2 streams are created in the same CCB, ccb_completed callback is called 2 times to verify the parameters then ccb_apply_create callbacks is called 2 time to create 2 new streams. Log service verifies stream file name by checking if the file name is duplicated with any exist streams.

    But in this case the verification pass:
    1/ No exist streams has file name "test3"
    2/ log service does not know if the stream "safLgStrCfg=test3" or "safLgStrCfg=test4" will created successfully or not. So why should reject if they are the same file name?

     

    Last edit: Canh Truong 2018-01-03
  • Canh Truong

    Canh Truong - 2018-01-11
    • status: assigned --> review
     
  • Anders Widell

    Anders Widell - 2018-02-02
    • Milestone: 5.18.01 --> 5.18.04
     
  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-02-07
    • status: review --> fixed
    • assigned_to: Canh Truong --> nobody
     
  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-02-07

    commit 44b9dd553f293ef4aefa723e70a6137f27fa50ce (HEAD, origin/develop, develop)
    Author: Canh Van Truong canh.v.truong@dektech.com.au
    Date: Thu Jan 11 12:33:15 2018 +0700

    log: fix to reject creating log streams with same file name in same CCB [#2752]
    
    LOG server should not allow creating streams which have the same target local log file
    
     

Log in to post a comment.