Menu

#2628 tools/amf: improve error checking and naming convention

5.17.11
fixed
Gary Lee
None
defect
amf
tools
minor
False
2017-10-30
2017-10-16
Gary Lee
No

amfclusterstatus expects the node ID in hex format. It should be consistent and prefix the node ID with 0x, in its output.

root@SC-1:~# amfclusterstatus -c 0x2010f
2010f is a Controller node

root@SC-1:~# amfclusterstatus -c 2010f
7da is not a Controller node

This is preferred:

root@SC-1:~# amfclusterstatus -u 0x2010f
0x2010f is up

In addition, invalid input prints:

root@SC-1:~# amfclusterstatus -u abc
0 is not up

Conflicting options are allowed:

root@SC-1:~# amfclusterstatus -u -c -s
At least one controller is up

Related

Wiki: ChangeLog-5.17.11

Discussion

  • Gary Lee

    Gary Lee - 2017-10-17

    Develop:

    commit 4094211ae3a59a1e1613c14dd9ae030aaa8be8f5
    Author: Gary Lee gary.lee@dektech.com.au
    Date: Wed Oct 18 10:46:06 2017 +1100

    amf: improve error checking and display [#2628]
    
    * nodes are prefixed with '0x', eg '0x2010f' instead of '2010f' to match input
    * options 's', 'c', 'u' are incompatible and are rejected when used together
    

    commit 0b0ba5726378026afba6cb7a6245a271207dff58
    Author: Gary Lee gary.lee@dektech.com.au
    Date: Wed Oct 18 10:46:06 2017 +1100

    amf: fix whitespace issues [#2628]
    
    whitespace changes only
    

    Release:

    commit af130d69d8c2aac4984643ee972cb6ddc39be416
    Author: Gary Lee gary.lee@dektech.com.au
    Date: Wed Oct 18 10:46:06 2017 +1100

    amf: improve error checking and display [#2628]
    
    * nodes are prefixed with '0x', eg '0x2010f' instead of '2010f' to match input
    * options 's', 'c', 'u' are incompatible and are rejected when used together
    

    commit 19901afa8183a750a5d540f7b9255e13c1d15f3b
    Author: Gary Lee gary.lee@dektech.com.au
    Date: Wed Oct 18 10:46:06 2017 +1100

    amf: fix whitespace issues [#2628]
    
    whitespace changes only
    
     
  • Gary Lee

    Gary Lee - 2017-10-17
    • status: accepted --> fixed
     

Log in to post a comment.