#2546 log: debug assertion failed in log agent during scale-in

[Vu Minh Nguyen]

During scaling in, LOG application got coredump due to assertion failed in log agent:

000000000000320e <LogClient::RestoreRefCounter(RefCounterDegree, bool)+0x18e="">:
_ZN9LogClient17RestoreRefCounterE16RefCounterDegreeb():
/src/log/agent/lga_client.cc:139 (discriminator 1)
320e: 48 8d 0d 8b a7 00 00 lea 0xa78b(%rip),%rcx # d9a0 <LogClient::RestoreRefCounter(RefCounterDegree, bool)::__PRETTY_FUNCTION__="">

Above disassembly points to this code line assert(ref_counter_ >= -1);

void LogClient::RestoreRefCounter(RefCounterDegree value, bool updated) {
  TRACE_ENTER();
  if (updated == false) return;
  ScopeLock scopeLock(ref_counter_mutex_);
  ref_counter_ -= value;
  TRACE("%s: value = %d", __func__, ref_counter_);
  // Don't expect the @ref_counter_ is less than (-1)
  assert(ref_counter_ >= -1);
}

[Vu Minh Nguyen]

[Develop]
commit a9a00db317978e4751213a2044a9dd99f6e548e8
Author: Vu Minh Nguyen vu.m.nguyen@dektech.com.au
Date: Wed Aug 9 10:17:31 2017 +0700

log: fix referring to uninitialized variable caused assertion failed [#2546]

[Release]
commit 44b0496ae3dea1d24908426ec6f2db97481e2859
Author: Vu Minh Nguyen vu.m.nguyen@dektech.com.au
Date: Wed Aug 9 10:17:31 2017 +0700

log: fix referring to uninitialized variable caused assertion failed [#2546]

[Vu Minh Nguyen]

Still encounter the coredump after including this fix. So, re-open the ticket.

[Vu Minh Nguyen]

Will re-open the ticket if encounter this fault again. Now consider it as fixed.