#2435 amf: make auto repair restriction optional

[Gary Lee]

Ticket #2144 added support for restricting auto-repair in accordance to the AMF spec. However, it has become clear some applications have relied on the legacy auto-repair behaviour. We now have a backwards compatibility issue. Therefore we should make the auto-repair restriction behavior optional, and make it default to the legacy haviour.

It is proposed to make this behaviour configurable via an attribute in a new AMF configuration object.

'''
diff --git a/src/amf/config/amf_classes.xml b/src/amf/config/amf_classes.xml
index ee0f185..d082990 100644
--- a/src/amf/config/amf_classes.xml
+++ b/src/amf/config/amf_classes.xml
@@ -1438,4 +1438,20 @@
<flag>SA_WRITABLE</flag>
</attr>
</class>
+ <class name="OpenSafAmfConfig">
+ <category>SA_CONFIG</category>
+ <rdn>
+ <name>amfConfig</name>
+ <type>SA_STRING_T</type>
+ <category>SA_CONFIG</category>
+ <flag>SA_INITIALIZED</flag>
+ </rdn>
+ <attr>
+ <name>amfRestrictAutoRepairEnable</name>
+ <type>SA_UINT32_T</type>
+ <category>SA_CONFIG</category>
+ <flag>SA_WRITABLE</flag>
+ <default-value>0</default-value>
+ </attr>
+ </class>
</imm:IMM-contents>
diff --git a/src/amf/config/amf_objects.xml b/src/amf/config/amf_objects.xml
index 502fc2f..31fc3e5 100644
--- a/src/amf/config/amf_objects.xml
+++ b/src/amf/config/amf_objects.xml
@@ -1,5 +1,12 @@
<?xml version="1.0" encoding="utf-8"?>
<imm:IMM-contents xmlns:imm="http://www.saforum.org/IMMSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="SAI-AIS-IMM-XSD-A.02.13.xsd">
+ <object class="OpenSafAmfConfig">
+ <dn>amfConfig=1,safApp=safAmfService</dn>
+ <attr>
+ <name>amfRestrictAutoRepairEnable</name>
+ <value>0</value>
+ </attr>
+ </object>
<object class="SaAmfAppBaseType">
<dn>safAppType=OpenSafApplicationType</dn>
</object>
'''

[Alex Jones]

This should default to ON because it is part of the spec.

Having AMF deal with this (instead of SMF) now allows someone to change this behavior in the middle of a campaign. This can be dangerous. Do we really want to allow this?

[Gary Lee]

commit 67fb026f7eaa8ca9febf74acf8ba09814777b160
Author: Gary Lee gary.lee@dektech.com.au
Date: Wed May 3 12:31:59 2017 +1000

amfd: make auto repair restriction configurable [#2435]

This adds a configuration object for AMF at amfConfig=1,safApp=safAmfService.

A configuration attribute 'amfRestrictAutoRepairEnable' is added.
This determines if 'suMaintenanceCampaign' should be ignored to maintain
legacy AMF behaviour. The default behaviour is to support auto repair
restriction.

To enable restriction:
immcfg -a osafAmfRestrictAutoRepairEnable=1 amfConfig=1,safApp=safAmfService

To disable restriction:
immcfg -a osafAmfRestrictAutoRepairEnable=0 amfConfig=1,safApp=safAmfService

commit 5607a0d7f9ef7e98c9db1613cf8f948b2d9fc138
Author: Gary Lee gary.lee@dektech.com.au
Date: Wed May 3 12:31:59 2017 +1000

amfd: make auto repair restriction configurable [#2435]

This adds a configuration object for AMF at amfConfig=1,safApp=safAmfService.

A configuration attribute 'amfRestrictAutoRepairEnable' is added.
This determines if 'suMaintenanceCampaign' should be ignored to maintain
legacy AMF behaviour. The default behaviour is to support auto repair
restriction.

To enable restriction:
immcfg -a osafAmfRestrictAutoRepairEnable=1 amfConfig=1,safApp=safAmfService

To disable restriction:
immcfg -a osafAmfRestrictAutoRepairEnable=0 amfConfig=1,safApp=safAmfService

changeset: 8788:e81cb8e250b2
tag: tip
user: Gary Lee gary.lee@dektech.com.au
date: Wed May 03 12:44:56 2017 +1000
summary: amfd: make auto repair restriction configurable [#2435]

[Gary Lee]

README files and AMF PR doc updated