#2428 Amf: Amfd crashes when su is unlocked

[Nagendra Kumar]

Steps to reproduce:

1. Start SC-1. Upload a demo app file.
   immcfg -f /tmp/AppConfig-2N.xml_t1
2. Delete CtCs object.
   immcfg -d "safSupportedCsType=safVersion=1\,safCSType=AmfDemo1,safVersion=1,safCompType=AmfDemo1"
3. Unlock-in the SU.
   amf-adm unlock-in safSu=SU1,safSg=AmfDemo_2N,safApp=AmfDemo1
4. Unlock the SU
   amf-adm unlock safSu=SU1,safSg=AmfDemo_2N,safApp=AmfDemo1

We got Amfd crash at:
Core was generated by `/usr/local/lib/opensaf/osafamfd --tracemask=0xffffffff'.
Program terminated with signal 11, Segmentation fault.

0 avd_snd_susi_msg(cl_cb_tag, AVD_SU, avd_su_si_rel_tag, AVSV_SUSI_ACT, bool, avd_comp_csi_rel_tag) () at src/amf/amfd/util.cc:701

701 return ctcs_type->saAmfCtCompCapability;

Bt is :
(gdb) bt

0 avd_snd_susi_msg(cl_cb_tag, AVD_SU, avd_su_si_rel_tag, AVSV_SUSI_ACT, bool, avd_comp_csi_rel_tag) () at src/amf/amfd/util.cc:701

1 0x00007fb48fd91e02 in avd_new_assgn_susi(cl_cb_tag, AVD_SU, AVD_SI, SaAmfHAStateT, bool, avd_su_si_rel_tag*) () at src/amf/amfd/sgproc.cc:242

2 0x00007fb48fd71340 in avd_sg_2n_su_chose_asgn(cl_cb_tag, AVD_SG) () at src/amf/amfd/sg_2n_fsm.cc:639

3 0x00007fb48fd718d1 in SG_2N::su_insvc(cl_cb_tag, AVD_SU) () at src/amf/amfd/sg_2n_fsm.cc:1373

4 0x00007fb48fdb2107 in AVD_SU::unlock(unsigned long long, unsigned long long) () at src/amf/amfd/su.cc:916

5 0x00007fb48fdb5a8a in su_admin_op_cb(unsigned long long, unsigned long long, SaNameT const, unsigned long long, SaImmAdminOperationParamsT_2 const*) () at src/amf/amfd/su.cc:1369

6 0x00007fb48fd41c20 in admin_operation_cb(unsigned long long, unsigned long long, SaNameT const, unsigned long long, SaImmAdminOperationParamsT_2 const*) () at src/amf/amfd/imm.cc:846

7 0x00007fb48f491937 in imma_process_callback_info(imma_cb, imma_client_node, imma_callback_info*, unsigned long long) () at src/imm/agent/imma_proc.cc:2119

8 0x00007fb48f492d89 in imma_hdl_callbk_dispatch_all(imma_cb*, unsigned long long) () at src/imm/agent/imma_proc.cc:1761

9 0x00007fb48f489a7f in saImmOiDispatch () at src/imm/agent/imma_oi_api.cc:638

10 0x00007fb48fcfdf48 in main () at src/amf/amfd/main.cc:729

The reason for the crash is in the function avd_snd_susi_msg(), get_comp_capability() is called with csi and comp as input parameter.
In the function, get_comp_capability(), there is no CtCs object available, so ctcstype_db->find returns NULL to ctcs_type.
While accessing ctcs_type->saAmfCtCompCapability, AMfd crashes because ctcs_type is NULL.

[Nagendra Kumar]

changeset: 8778:a1ca2c766c05
branch: opensaf-5.0.x
parent: 8756:70641a68bff2
user: Nagendra Kumarnagendra.k@oracle.com
date: Tue Apr 25 13:42:46 2017 +0530
files: osaf/services/saf/amf/amfd/ctcstype.cc
description:
amfd: disallow delete of CtCs object if Ct maps to comp [#2428]

changeset: 8779:0d02ff4fc258
branch: opensaf-5.1.x
parent: 8772:ce4e365ccdab
user: Nagendra Kumarnagendra.k@oracle.com
date: Thu Apr 27 13:51:14 2017 +0530
files: osaf/services/saf/amf/amfd/ctcstype.cc
description:
amfd: disallow delete of CtCs object if Ct maps to comp [#2428]

changeset: 8780:60f03201680c
tag: tip
parent: 8777:dc60670bfd3b
user: Nagendra Kumarnagendra.k@oracle.com
date: Thu Apr 27 13:51:41 2017 +0530
files: src/amf/amfd/ctcstype.cc
description:
amfd: disallow delete of CtCs object if Ct maps to comp [#2428]