#2268 amf: assignment from higher ranked SU is removed in N-Way Active model.

[Praveen]

When saAmfSIPrefActiveAssignments is reduced, AMFD removes assignments from higher ranked SU when siranked su is not configured.
Steps to reproduce:
1) Bring attached application up on one controller.
2) The only SI is assigned to three SUs. Three SUs have different SURanks. Pref active assignments for SI is 3.
3) Reduce pref active assignment for the SI by running following command:
immcfg -a saAmfSIPrefActiveAssignments=2 safSi=NWay_Active,safApp=NWay_Active
4)Since pref active assignments is reduced by 1, AMFD sends quiesced and removal of assignment to SU2.
5)SU2 has rank2. Assignments should be removed from SU3 which has rank 3.

Assignments before reducing pref active assignmets:
safSISU=safSu=SU1\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1)
safSISU=safSu=SU2\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1)
safSISU=safSu=SU3\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1)

Assignments after reducing pre active assignments:
safSISU=safSu=SU1\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1)
safSISU=safSu=SU3\,safSg=NWay_Active\,safApp=NWay_Active,safSi=NWay_Active,safApp=NWay_Active
saAmfSISUHAState=ACTIVE(1)
saAmfSISUHAReadinessState=READY_FOR_ASSIGNMENT(1)

[Praveen]

Similar issue in N-Way model also when SiPrefStandbyAssignment is reduced. Also AMFD is not checking the HA state of the susi and tries to delete active susi and crashes:

Mar 8 11:38:25 SC-1 osafimmnd[4765]: NO Ccb 4 COMMITTED (immcfg_SC-1_5673)
Mar 8 11:38:25 SC-1 amf_demo[5464]: ========>CSI Remove=====>
Mar 8 11:38:25 SC-1 amf_demo[5464]: Comp---->:'safComp=NWay,safSu=SU1,safSg=NWay,safApp=NWay'
Mar 8 11:38:25 SC-1 amf_demo[5464]: CSI------>:'safCsi=NWay,safSi=NWay,safApp=NWay'
Mar 8 11:38:25 SC-1 amf_demo[5464]: CSI FLAG------>: SA_AMF_CSI_TARGET_ONE
Mar 8 11:38:25 SC-1 amf_demo[5464]: <=======================
Mar 8 11:38:25 SC-1 osafamfnd[4817]: NO Removed 'safSi=NWay,safApp=NWay' from 'safSu=SU1,safSg=NWay,safApp=NWay'
Mar 8 11:38:25 SC-1 amf_demo[5464]: saAmfResponse after lopp- 1
Mar 8 11:38:25 SC-1 amf_demo[5494]: ========>CSI Remove=====>
Mar 8 11:38:25 SC-1 amf_demo[5494]: Comp---->:'safComp=NWay,safSu=SU2,safSg=NWay,safApp=NWay'
Mar 8 11:38:25 SC-1 amf_demo[5494]: CSI------>:'safCsi=NWay,safSi=NWay,safApp=NWay'
Mar 8 11:38:25 SC-1 amf_demo[5494]: CSI FLAG------>: SA_AMF_CSI_TARGET_ONE
Mar 8 11:38:25 SC-1 amf_demo[5494]: <=======================
Mar 8 11:38:25 SC-1 osafamfnd[4817]: NO Removed 'safSi=NWay,safApp=NWay' from 'safSu=SU2,safSg=NWay,safApp=NWay'
Mar 8 11:38:25 SC-1 amf_demo[5494]: saAmfResponse after lopp- 1
Mar 8 11:38:25 SC-1 osafamfd[4803]: src/amf/amfd/su.cc:2072: dec_curr_stdby_si: Assertion 'saAmfSUNumCurrStandbySIs > 0' failed.
Mar 8 11:38:25 SC-1 osafamfnd[4817]: ER AMFD has unexpectedly crashed. Rebooting node
Mar 8 11:38:25 SC-1 osafamfnd[4817]: Rebooting OpenSAF NodeId = 131343 EE Name = , Reason: AMFD has unexpectedly crashed. Rebooting node, OwnNodeId = 131343, SupervisionTime = 60
Mar 8 11:38:25 SC-1 osafimmnd[4765]: NO Implementer locally disconnected. Marking it as doomed 31 <23, 2010f> (safAmfService)
Mar 8 11:38:25 SC-1 osafimmnd[4765]: NO Implementer disconnected 31 <23, 2010f> (safAmfService)
Mar 8 11:38:25 SC-1 opensaf_reboot: Rebooting local node; timeout=60

[Praveen]

changeset: 8718:8d305dff2257
branch: opensaf-5.0.x
parent: 8715:dae6b6197639
user: Praveen Malviya praveen.malviya@oracle.com
date: Thu Mar 23 12:34:04 2017 +0530
summary: amfd: remove assignments from lower ranked SU while adjusting SI assignments [#2268]

changeset: 8719:263af6bf5c65
branch: opensaf-5.1.x
parent: 8716:8d149783d95a
user: Praveen Malviya praveen.malviya@oracle.com
date: Thu Mar 23 12:35:03 2017 +0530
summary: amfd: remove assignments from lower ranked SU while adjusting SI assignments [#2268]

changeset: 8720:057a8a4b1a99
tag: tip
parent: 8717:6cffd8965ae4
user: Praveen Malviya praveen.malviya@oracle.com
date: Thu Mar 23 12:36:49 2017 +0530
summary: amfd: remove assignments from lower ranked SU while adjusting SI assignments [#2268]

[staging:8d305d]
[staging:263af6]
[staging:057a8a]