Menu

#2198 imm: Multiple definitions of IMM_VALIDATION_ABORT and IMM_RESOURCE_ABORT

5.0.2
fixed
None
defect
imm
-
5.2.M0
minor
2016-12-13
2016-11-22
No

The constants IMM_VALIDATION_ABORT and IMM_RESOURCE_ABORT are define at multiple locations:

$ grep -r _ABORT immsv/|grep define
immsv/immnd/immnd_evt.c:#define IMM_VALIDATION_ABORT    "IMM: Validation abort: "
immsv/immnd/immnd_evt.c:#define IMM_RESOURCE_ABORT      "IMM: Resource abort: "
immsv/immnd/ImmModel.cc:#define IMM_VALIDATION_ABORT  "IMM: Validation abort: "
immsv/immnd/ImmModel.cc:#define IMM_RESOURCE_ABORT    "IMM: Resource abort: "

The definitions ought to be moved to one single header file, to avoid code duplication and the risk of divergence (spelling mistakes in one of the definitions but not the other, etc.).

Related

Tickets: #2198
Wiki: ChangeLog-5.0.2
Wiki: ChangeLog-5.1.1

Discussion

  • Zoran Milinkovic

    • status: unassigned --> accepted
    • assigned_to: Zoran Milinkovic
     
  • Zoran Milinkovic

     
  • Zoran Milinkovic

    Affected branches: opensaf-5.0.x, opensaf-5.1.x, default(5.2)
    Development branch: default(5.2)

    https://sourceforge.net/p/opensaf/mailman/message/35539338/

     
  • Zoran Milinkovic

    • status: accepted --> review
     
  • Zoran Milinkovic

    • status: review --> fixed
     
  • Zoran Milinkovic

    opensaf-5.0.x:

    changeset: 8438:5fba82ddf21f
    branch: opensaf-5.0.x
    parent: 8429:91b55c7c9848
    user: Zoran Milinkovic zoran.milinkovic@ericsson.com
    date: Thu Dec 08 14:30:43 2016 +0100
    summary: imm: move IMM error string prefixes to header file [#2198]


    opensaf-5.1.x:

    changeset: 8439:62a68f4fb03a
    branch: opensaf-5.1.x
    parent: 8430:3f26fac74227
    user: Zoran Milinkovic zoran.milinkovic@ericsson.com
    date: Thu Dec 08 14:30:43 2016 +0100
    summary: imm: move IMM error string prefixes to header file [#2198]


    default(5.2):

    changeset: 8440:805f11e83193
    tag: tip
    parent: 8437:1a479e952a20
    user: Zoran Milinkovic zoran.milinkovic@ericsson.com
    date: Thu Dec 08 14:30:43 2016 +0100
    summary: imm: move IMM error string prefixes to header file [#2198]

     

    Related

    Tickets: #2198


Log in to post a comment.