#2169 amf: su containing proxy comps is not working properly after a su restart recovery

[Long H Buu Nguyen]

• Description:
  When a proxy component restart is escalated to a su restart, then the SU is not working properly after that (e.g. lock failed).

• Reproduction:
  1) Use the proxy demo in amf samples.
  2) Unlock-in/unlock proxy SU, proxied SU.
  3) Kill the proxy process some times to take the recovery escalation from comp restart to su restart.
  4) Lock the proxy SU => timeout.

[Nagendra Kumar]

Hi Long HB Nguyen, Can you please update the version or change set.

[Nagendra Kumar]

Also, please share the config file(.xml) or configuration details.

[Long H Buu Nguyen]

Hi Nagu,

The changeset is 8272. I used the proxy demo and the config file (.xml) in samples/amf/proxy.

[Nagendra Kumar]

Hi Long HB Nguyen,
Can you please test the patch and let me know today if possible.

Thanks
-Nagu

[Long H Buu Nguyen]

Hi Nagu,

I have tested the patch (the log is attached). It is working fine and the proxy component gets CLEANUP.
In your patch, you have fixed for the case that Proxy and Proxied comp are not in the same SU. In the case, they are in the same SU, the behavior is different (i.e. still return immediately). Could you please share the idea behind that?

Thanks,
Long Nguyen.

[Nagendra Kumar]

Yes. If proxy and proxied are in the same SU, then proxy need to be cleaned in the last as cleanup command of proxied is first given to proxy. If proxy are killed first then there will not be any way to kill proxied components.
I assume you have acked the patch and I am going to push it.

[Nagendra Kumar]

searching for changes
changeset: 8294:88be3d560de2
branch: opensaf-5.0.x
parent: 8291:578552651e82
user: Nagendra Kumarnagendra.k@oracle.com
date: Wed Nov 09 11:38:02 2016 +0530
summary: amfnd: clean proxy if proxy and proxied are not in the same SU [#2169]

changeset: 8295:4879318abbe5
branch: opensaf-5.1.x
parent: 8292:a029795d9845
user: Nagendra Kumarnagendra.k@oracle.com
date: Wed Nov 09 11:38:21 2016 +0530
summary: amfnd: clean proxy if proxy and proxied are not in the same SU [#2169]

changeset: 8296:0bcf2b782bcc
tag: tip
parent: 8293:135eb53abf6f
user: Nagendra Kumarnagendra.k@oracle.com
date: Wed Nov 09 11:38:40 2016 +0530
summary: amfnd: clean proxy if proxy and proxied are not in the same SU [#2169]

[Nagendra Kumar]

Hi Long HB Nguyen,
I assumed that you had code doubt about "still return immediately" and it is not creating any problem. Can you please confirm that this problem exist with the SU having proxy and proxied components has the same issue. If yes, create a separate ticket as this ticket was raised as per samples/amf/proxy and in that sample, SUs of proxy and proxied components are different.

Thanks
-Nagu

[Long H Buu Nguyen]

Hi Nagu,

Originally, I only tested the case that a proxy component and a proxied component are not in the same SU (i.e. samples/amf/proxy). However, when looking into the code, I think that it may have the same problem with the case that a proxy and a proxied component are in the same SU. That is the reason I asked. However, I have not tested that case with your code.

Thanks,
Long Nguyen.

[Nagendra Kumar]

Ok, thanks for the information, I will test it.

[Long H Buu Nguyen]

Hi Nagu,

In case you want to fix for that case. You can open a ticket yourself.

Best regards,
Long Nguyen.

[Nagendra Kumar]

Raised https://sourceforge.net/p/opensaf/tickets/2186/