Menu ▾ ▴

#2132 mds: Remove use of mutex at TIPC receive

5.2.FC
fixed
Hans Nordebäck
None
enhancement
mds
-
major
2016-12-14
2016-10-20
Hans Nordebäck
No

As a first step in imporving the MDS recv of TIPC events by changing data socket and bsr socket to nonblocking and loop over recv til EWOULDBLOCK or EAGAIN. Also changing to handle each descriptor before entering the poll loop. This to reduce the mutex lock contention. As a next step it this global mutex lock. See also [#1966]

Related

Tickets: #1966
Tickets: #2132
Wiki: NEWS-5.2.0

Discussion

  • Hans Nordebäck

    Hans Nordebäck - 2016-10-20
    • summary: mds: Improve recv of events --> mds: Improve recv of TIPC events
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1 @@
-As a first step in imporving the MDS recv of events by changing data socket and bsr socket to nonblocking and loop over recv til EWOULDBLOCK or EAGAIN. Also changing to handle each descriptor before entering the poll loop. This to reduce the mutex lock contention. As a next step it would be good to remove the mutex lock.
+As a first step in imporving the MDS recv of TIPC events by changing data socket and bsr socket to nonblocking and loop over recv til EWOULDBLOCK or EAGAIN. Also changing to handle each descriptor before entering the poll loop. This to reduce the mutex lock contention. As a next step it would be good to remove the mutex lock.
     

  • Hans Nordebäck

    Hans Nordebäck - 2016-10-21
    • summary: mds: Improve recv of TIPC events --> mds: Remove use of mutex at TIPC receive
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1 @@
-As a first step in imporving the MDS recv of TIPC events by changing data socket and bsr socket to nonblocking and loop over recv til EWOULDBLOCK or EAGAIN. Also changing to handle each descriptor before entering the poll loop. This to reduce the mutex lock contention. As a next step it would be good to remove the mutex lock.
+As a first step in imporving the MDS recv of TIPC events by changing data socket and bsr socket to nonblocking and loop over recv til EWOULDBLOCK or EAGAIN. Also changing to handle each descriptor before entering the poll loop. This to reduce the mutex lock contention. As a next step it this global mutex lock. See also #1966
     

  • Hans Nordebäck

    Hans Nordebäck - 2016-10-21
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1 +1 @@
-As a first step in imporving the MDS recv of TIPC events by changing data socket and bsr socket to nonblocking and loop over recv til EWOULDBLOCK or EAGAIN. Also changing to handle each descriptor before entering the poll loop. This to reduce the mutex lock contention. As a next step it this global mutex lock. See also #1966
+As a first step in imporving the MDS recv of TIPC events by changing data socket and bsr socket to nonblocking and loop over recv til EWOULDBLOCK or EAGAIN. Also changing to handle each descriptor before entering the poll loop. This to reduce the mutex lock contention. As a next step it this global mutex lock. See also [#1966]
     

    Related

    Tickets: #1966

  • Hans Nordebäck

    Hans Nordebäck - 2016-10-25
    • status: assigned --> review
     

  • Hans Nordebäck

    Hans Nordebäck - 2016-12-14
    • status: review --> fixed
     

  • Hans Nordebäck

    Hans Nordebäck - 2016-12-14

    changeset: 8441:48b0807e10f8
    user: Hans Nordeback hans.nordeback@ericsson.com
    date: Wed Dec 07 12:34:16 2016 +0100
    files: osaf/libs/core/mds/mds_dt_tipc.c
    description:
    mds: Remove use of mutex at TIPC receive (part 1) V6 [#2132]

    This first part changes the socket descriptors to non blocking at receive.
    This to read all incoming messages before returning to the next poll call.

     

    Related

    Tickets: #2132

Log in to post a comment.