#2131 imm: Crash due to improper error handling

[Anders Widell]

The following crash has been observed in the IMM agent, due to improper cleanup in the error handling path:

Program terminated with signal SIGABRT, Aborted.
#0  0x0000000041620c37 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
56      ../nptl/sysdeps/unix/sysv/linux/raise.c: No such file or directory.
(gdb) bt
#0  0x0000000041620c37 in __GI_raise (sig=sig@entry=6) at ../nptl/sysdeps/unix/sysv/linux/raise.c:56
#1  0x0000000041624028 in __GI_abort () at abort.c:89
#2  0x00000000409cb50b in osaf_abort (i_cause=22) at osaf_utility.c:33
#3  0x00000000409e50ce in osaf_mutex_lock_ordie (io_mutex=0x40e937f8 <imma_cb+24>)
    at ../../../../osaf/libs/core/common/include/osaf_utility.h:80
#4  ncs_os_lock (lock=0x40e937f8 <imma_cb+24>, request=NCS_OS_LOCK_LOCK, type=2) at os_defs.c:418
#5  0x0000000040c6b0c7 in imma_mds_svc_evt (cb=0x40e937e0 <imma_cb>, svc_evt=0x44000a60) at imma_mds.c:438
#6  0x0000000040c6ab79 in imma_mds_callback (info=0x44000a50) at imma_mds.c:221
#7  0x0000000040a19045 in mds_mcm_user_event_callback (local_svc_hdl=562945658454042, pwe_id=1, svc_id=25, role=V_DEST_RL_ACTIVE, 
    vdest_id=65535, adest=566312962504486, event_type=NCSMDS_UP, svc_sub_part_ver=1 '\001', archword_type=10 '\n') at mds_c_api.c:3363
#8  0x0000000040a147b6 in mds_mcm_svc_up (pwe_id=1, svc_id=25, role=V_DEST_RL_ACTIVE, scope=NCSMDS_SCOPE_NONE, vdest_id=65535, 
    vdest_policy=NCS_VDEST_TYPE_N_WAY_ROUND_ROBIN, adest=566312962504486, my_pcon=false, local_svc_hdl=562945658454042, subtn_ref_val=1, 
    svc_sub_part_ver=1 '\001', archword_type=10 '\n') at mds_c_api.c:1615
#9  0x0000000040a1e64e in mdtm_process_discovery_events (discovery_event=1, event=...) at mds_dt_tipc.c:1006
#10 0x0000000040a1daca in mdtm_process_recv_events () at mds_dt_tipc.c:693
#11 0x0000000040798184 in start_thread (arg=0x4006cb00) at pthread_create.c:312
#12 0x00000000416e437d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb)

[Anders Widell]

changeset: 8244:85d4a2c924b8
branch: opensaf-5.0.x
parent: 8239:34b4a35930c5
user: Anders Widell an..@..com
date: Fri Oct 21 09:42:33 2016 +0200
summary: imm: Fix error handling path when imma_sync_with_immnd fails [#2131]

changeset: 8245:f333c128afdf
branch: opensaf-5.1.x
parent: 8242:a419ee7f46dd
user: Anders Widell an..@..com
date: Fri Oct 21 09:42:33 2016 +0200
summary: imm: Fix error handling path when imma_sync_with_immnd fails [#2131]

changeset: 8246:7e13de9041dd
parent: 8243:93a22ddd5a7c
user: Anders Widell an..@..com
date: Fri Oct 21 09:42:33 2016 +0200
summary: imm: Fix error handling path when imma_sync_with_immnd fails [#2131]

[staging:85d4a2]
[staging:f333c1]
[staging:7e13de]