#1998 amf: protection group track non existing csi returns SA_AIS_ERR_INIT

[Long H Buu Nguyen]

Steps to reproduce

• Use 2N model.
• Modify amf_demo.c as follow:
  • Initialze amf_demo with saAmfInitialize_4 or saAmfInitialize_o4.
  • Add a callback for protection group.
  • Call saAmfProtectionGroupTrack with a non-existing csi (e.g. "dummy" csi), the flag is SA_TRACK_CURRENT and notificationBuffer is NULL.

Observed behaviour

Before the patches for #1553 were pushed, the testcase had returned SA_AIS_ERR_NOT_EXIST return code.
After the patches for #1553 were pushed, the testcase has returned SA_AIS_ERR_INIT return code.

Initial investigation:

In the patches for #1553, Praveen added an internal callback structure (OsafAmfCallbacksT):
The structure divides protection track callback in two cases:
- SaAmfProtectionGroupTrackCallbackT for versions older than B.04.01.
- SaAmfProtectionGroupTrackCallbackT_4 for versions from B.04.01.

In the case that amf_demo is initialized with callbacks for B.04.01 (i.e. saAmfProtectionGroupTrackCallback_4 is set). When amf_demo call saAmfProtectionGroupTrack, amfa checks saAmfProtectionGroupTrackCallback (it is NULL now).
Then, amfa returns SA_AIS_ERR_INIT.

​

[Long H Buu Nguyen]

default: [staging:36f63c]
changeset: 8005:36f63cf5aa4d
parent: 8003:4dfd86ce806e
user: Long Nguyen long.hb.nguyen@dektech.com.au
date: Tue Sep 06 17:10:19 2016 +1000
summary: amfa: fix pg track returns SA_AIS_ERR_INIT [#1998]

opensaf-5.1.x: [staging:f8bc9f]
changeset: 8006:f8bc9f897235
branch: opensaf-5.1.x
tag: tip
parent: 8004:a7ed45608a5b
user: Long Nguyen long.hb.nguyen@dektech.com.au
date: Tue Sep 06 17:12:58 2016 +1000
summary: amfa: fix pg track returns SA_AIS_ERR_INIT [#1998]