#1897 Incorrect ER messages in syslog

[elunlen]

Several incorrectly prioritized syslog messages found in SG_2N::si_swap in sg_2n_fsm.cc
LOG_ER is used when problem is easily recoverable e.g. return value is SA_AIS_ERR_TRY_AGAIN

[Long H Buu Nguyen]

I think amfd should use LOG_NO in this case since it returns TRY_AGAIN.
It is also to be consistent to si_swap() function in sg_nway_fsm.cc.

[Long H Buu Nguyen]

default: [staging:1f7da3]
changeset: 8242:1f7da38c884b
parent: 8239:b0d4fb1ac1a1
user: Long Nguyen long.hb.nguyen@dektech.com.au
date: Wed Oct 19 14:43:55 2016 +1100
summary: amfd: fix incorrect ER messages in sg_2n_fsm.cc [#1897]

opensaf-5.1.x: [staging:965818]
changeset: 8243:9658183440ce
branch: opensaf-5.1.x
parent: 8240:08c741038adf
user: Long Nguyen long.hb.nguyen@dektech.com.au
date: Wed Oct 19 14:44:38 2016 +1100
summary: amfd: fix incorrect ER messages in sg_2n_fsm.cc [#1897]

opensaf-5.0.x: [staging:439400]
changeset: 8244:4394005ebe24
branch: opensaf-5.0.x
tag: tip
parent: 8241:914ffbc1a71c
user: Long Nguyen long.hb.nguyen@dektech.com.au
date: Wed Oct 19 14:47:06 2016 +1100
summary: amfd: fix incorrect ER messages in sg_2n_fsm.cc [#1897]

[Gary Lee]

Reopening as changes in this ticket were reverted when #1294 was pushed. We need to reapply the changes.

[Gary Lee]

changeset: 8526:88555159b006
branch: opensaf-5.0.x
parent: 8516:72b4ef9124d8
user: Gary Lee gary.lee@dektech.com.au
date: Fri Jan 20 16:02:54 2017 +1100
summary: amfd: use more appropriate log severity levels in si_swap_validate() [#1897]

changeset: 8525:7336414d6a07
branch: opensaf-5.1.x
parent: 8520:46d2a32bd152
user: Gary Lee gary.lee@dektech.com.au
date: Fri Jan 20 15:37:16 2017 +1100
summary: amfd: use more appropriate log severity levels in si_swap_validate() [#1897]

changeset: 8524:2605957a234b
user: Gary Lee gary.lee@dektech.com.au
date: Fri Jan 20 15:17:07 2017 +1100
summary: amfd: use more appropriate log severity levels in si_swap_validate() [#1897]

[Rafael Odzakow]

Consider to change LOG_NO to TRACE in case multiple try again would spam the system log.