Menu ▾ ▴

#1775 osaf: Reduce the amount of warnings reported by cpplint

4.7.2
fixed
Anders Widell
None
enhancement
build
-
minor
2016-05-26
2016-04-21
Anders Widell
No

Reduce the number of warnings reported by the cpplint tool in the OpenSAF source code. Some warnings might be ok, since this tool produces false positives. These warnings should be suppressed by inserting // NOLINT or // NOLINTNEXTLINE.

This is a ticket for adding support for the cpplint build target in the Makefiles. We should open tickets in affected services to fix the actual problems that are discovered. Serious bugs should be fixed in all maintained branches. Minor bugs and style problems should be fixed on the default branch only.

Related

Tickets: #1775
Tickets: #1838
Wiki: ChangeLog-4.7.2
Wiki: ChangeLog-5.0.1

Discussion

  • Anders Widell

    Anders Widell - 2016-05-25
    • status: unassigned --> accepted
    • assigned_to: Anders Widell
    • Milestone: 5.1.FC --> 4.7.2
     

  • Anders Widell

    Anders Widell - 2016-05-26
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,3 +1,3 @@
 Reduce the number of warnings reported by the [cpplint](https://google.github.io/styleguide/cppguide.html#cpplint) tool in the OpenSAF source code. Some warnings might be ok, since this tool produces false positives. These warnings should be suppressed by inserting **// NOLINT** or **// NOLINTNEXTLINE**.

-This is a global ticket for OpenSAF. Each OpenSAF service might want to have its own ticket for their respective service.
+This is a ticket for adding support for the cpplint build target in the Makefiles. We should open tickets in affected services to fix the actual problems that are discovered. Serious bugs should be fixed in all maintained branches. Minor bugs and style problems should be fixed on the default branch only.
    • status: accepted --> fixed
    • Component: osaf --> build
     

Log in to post a comment.