#1761 Amf: Standby Amfd crash during SU delete

[Nagendra Kumar]

Similar as https://sourceforge.net/p/opensaf/tickets/1683/

Steps to reproduce:

1. Start one controllers.
2. Upload the Amf demo configuration hosting two SUs on SC-1.
3. In Standby Amfd keep a sleep of 7 sec after confg read and before applier set as below:

+++ b/osaf/services/saf/amf/amfd/role.cc
@@ -219,6 +219,9 @@ uint32_t avd_standby_role_initialization
}
cb->init_state = AVD_CFG_DONE;
LOG_ER("1. Waiting ..........................");
sleep(7);
LOG_ER("2. Waiting ..........................");

if (avd_imm_applier_set() != SA_AIS_OK) {
        LOG_ER("avd_imm_applier_set FAILED");

1. Start Standby controller. When Amfd comes up and waiting for 7 sec, delete Comp as below:
   immcfg -d safComp=AmfDemo,safSu=SU1,safSg=AmfDemo_2N,safApp=AmfDemo1
2. When Amfd wakes up and become applier, delete SU:
   immcfg -d safSu=SU1,safSg=AmfDemo_2N,safApp=AmfDemo1

Observed behaviour:

Standby Amfd crashes at su.cc:89: remove_from_model: Assertion 'list_of_comp.empty() == true' failed.
Describe how the system behaved

Expected behaviour

Standby Amfd shouldn't crash.

Error messages

SC-2 osafamfd[9043]: su.cc:89: remove_from_model: Assertion 'list_of_comp.empty() == true' failed.

[Nagendra Kumar]

changeset: 7527:b4aa5541def6
branch: opensaf-4.6.x
parent: 7521:3317f6c45513
user: Nagendra Kumarnagendra.k@oracle.com
date: Fri Apr 22 16:09:12 2016 +0530
summary: amfd: delete comp and its child objects at stdby amfd [#1761]

changeset: 7528:f43a3138f8df
branch: opensaf-4.7.x
parent: 7522:e2c01073de3f
user: Nagendra Kumarnagendra.k@oracle.com
date: Fri Apr 22 16:09:22 2016 +0530
summary: amfd: delete comp and its child objects at stdby amfd [#1761]

changeset: 7529:02d711bb350e
branch: opensaf-5.0.x
parent: 7525:7cee8f0880c0
user: Nagendra Kumarnagendra.k@oracle.com
date: Fri Apr 22 16:09:48 2016 +0530
summary: amfd: delete comp and its child objects at stdby amfd [#1761]

changeset: 7530:8a40a9170d7e
tag: tip
parent: 7526:5d4fea688366
user: Nagendra Kumarnagendra.k@oracle.com
date: Fri Apr 22 16:09:55 2016 +0530
summary: amfd: delete comp and its child objects at stdby amfd [#1761]

[staging:b4aa55]
[staging:f43a31]
[staging:02d711]
[staging:8a40a9]

[Nagendra Kumar]

changeset: 7531:52ee7f783197
branch: opensaf-4.6.x
tag: tip
parent: 7527:b4aa5541def6
user: Nagendra Kumarnagendra.k@oracle.com
date: Fri Apr 22 17:02:37 2016 +0530
summary: amfd: fix compilation issue [#1761]