clm: clmsv sends msg based ckpt before cold sync is complete

Brought to you by: anders-w, gary_lee, hansnordeback, jonasarndt, and 4 others

#1701 clm: clmsv sends msg based ckpt before cold sync is complete

Milestone: 5.0.GA

Status: fixed

Owner: Hans Nordebäck

Labels: None

Type: defect

Component: clm

Part: d

Version:

Priority: major

Blocker:

Updated: 2016-05-03

Created: 2016-03-15

Creator: Hans Nordebäck

Private: No

At start of the standby clmsv a msg based ckpt may arrive before cold sync is completed. This leads to ckpt_proc_reg_rec() is called for the same client_id twice and the global clms_cb->last_client_id is not correct as it is not updated the second time at cold sync, already exists.

After role change, standby to active, proc_initialize_msg tries to add a new client_id, that already exists, due to the above described inconsistency. The clma agent receives this message as the somewhat misleading error message SA_AIS_ERR_NO_MEMORY at the clma.

A patch to avoid sending msg based checkpoints before cold sync is complete solves this problem.

3 Attachments

osafclmd

osafclmd_sc1

syslog_sc2

Related

Tickets: ~~#1701~~
Tickets: ~~#1738~~

Discussion

Hans Nordebäck - 2016-03-17

status: review --> fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Hans Nordebäck - 2016-03-17

changeset: 7327:4ed808a6af5b
tag: qparent
user: Hans Nordeback hans.nordeback@ericsson.com
date: Tue Mar 15 13:59:58 2016 +0100
files: osaf/services/saf/clmsv/clms/clms_mbcsv.c
description:
clmd: Wait for cold sync to complete before sending message based checkpoints [#1701]

Related

Tickets: ~~#1701~~

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nagendra Kumar - 2016-04-14

The fix is causing the issue https://sourceforge.net/p/opensaf/tickets/1738/

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nagendra Kumar - 2016-04-14

Looks causing https://sourceforge.net/p/opensaf/tickets/1760/ as well.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-04-14

I was perhaps in a haste to ack this patch, but i think this patch (and probably combined with behavioural changes introduced in 79 i.e. longer election timeout might create problems) could create the issues described in the tickets highlighted in 1738, 1760.
Need to see if 1762 too is somewhat related to this.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-04-15

This may not be related to 1762. And 1760 looks different too.
Evaluating 1738 now!

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-04-24

status: fixed --> unassigned

Milestone: 5.0.FC --> 5.0.RC2
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-04-24

The only change related to checkpointing was introduced in the fix of ticket 1701.
So, given that 1738, 1762 is not reproduced if 1701 is removed and given that this ticket also has the same pattern, i have reverted 1701 patch as a fix for the 3 tickets 1738, 1726 and 1777.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-04-24

Priority: major --> minor
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-04-24

This ticket is reopened for tracking and setting the priority for minor.
Additional information like steps to reproduce, logs, traces would help.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-04-24

Milestone: 5.0.RC2 --> 5.0.GA
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Hans Nordebäck - 2016-04-25

Attachments has changed:

Diff:

--- old +++ new @@ -0,0 +1 @@ +osafclmd (3.6 MB; application/octet-stream)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Hans Nordebäck - 2016-04-25

Attachments has changed:

Diff:

--- old +++ new @@ -1 +1,2 @@ osafclmd (3.6 MB; application/octet-stream) +syslog_sc2 (230.5 kB; application/octet-stream)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Hans Nordebäck - 2016-04-25

Priority: minor --> major
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Hans Nordebäck - 2016-04-26

Attachments has changed:

Diff:

--- old +++ new @@ -1,2 +1,3 @@ osafclmd (3.6 MB; application/octet-stream) +osafclmd_sc1 (2.7 MB; application/octet-stream) syslog_sc2 (230.5 kB; application/octet-stream)
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-05-02

status: unassigned --> accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-05-03

Attached v3 of the fix provided by HansN and GaryL. Thanks for retesting, sharing traces and providing a fix. Unfortunately the issue is not reproducible for me.

1701_v3.diff

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-05-03

status: accepted --> fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Mathi Naickan - 2016-05-03

Pushed after making a trivial change to the log string.

[staging:ee924d]
[staging:2f8255]
[staging:06f276]
[staging:742b76]

changeset: 7579:ee924d090c55
branch: opensaf-5.0.x
parent: 7574:af17916c8873
user: Hans Nordeback hans.nordeback@ericsson.com
date: Tue May 03 12:04:49 2016 +0530
summary: clm: fix handling of last_client_id at standby|quiesced [#1701]

changeset: 7580:2f8255951950
parent: 7578:fa4a30bbdd27
user: Hans Nordeback hans.nordeback@ericsson.com
date: Tue May 03 12:04:49 2016 +0530
summary: clm: fix handling of last_client_id at standby|quiesced [#1701]

changeset: 7581:06f2761901e6
branch: opensaf-5.0.x
parent: 7579:ee924d090c55
user: Gary Lee gary.lee@dektech.com.au
date: Tue May 03 12:12:31 2016 +0530
summary: clm: change log category from ER to NO when clms_client_delete fails at standby [#1701]

changeset: 7582:742b765c3d97
tag: tip
parent: 7580:2f8255951950
user: Gary Lee gary.lee@dektech.com.au
date: Tue May 03 12:12:31 2016 +0530
summary: clm: change log category from ER to NO when clms_client_delete fails at standby [#1701]

Related

Commit: [06f276]
Commit: [2f8255]
Commit: [742b76]
Commit: [ee924d]
Tickets: ~~#1701~~

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.