Menu ▾ ▴

#1303 IMM: APIs assert when the length of the object using SaNameT is more than 256

4.5.2
fixed
Zoran Milinkovic
None
defect
imm
lib
4.6 FC
minor
2015-04-14
2015-04-06
Sirisha Alla
No

This issue is seen on changeset 6377 (46FC Tag). When IMM agents using old APIs (having SaNameT) specifies the length of object greater than 256, application asserts.

bt of the core:

Program terminated with signal 6, Aborted.
#0 0x00007fe800983b55 in raise () from /lib64/libc.so.6
(gdb) bt
#0 0x00007fe800983b55 in raise () from /lib64/libc.so.6
#1 0x00007fe800985131 in abort () from /lib64/libc.so.6
#2 0x00007fe7ffe2437a in __osafassert_fail () from /usr/lib64/libopensaf_core.so.0
#3 0x00007fe7ffe204b3 in osaf_extended_name_length () from /usr/lib64/libopensaf_core.so.0
#4 0x00007fe8000a2dac in saImmOmAdminOperationInvoke_o2 () at imma_om_api.c:3569

Till 4.5 INVALID_PARAM is returned to the application.

Related

Tickets: #1303
Wiki: ChangeLog-4.5.2
Wiki: ChangeLog-4.6.1

Discussion

  • Sirisha Alla

    Sirisha Alla - 2015-04-06
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -3,12 +3,12 @@
 bt of the core:

 Program terminated with signal 6, Aborted.
-#0  0x00007fe800983b55 in raise () from /lib64/libc.so.6
+  #0  0x00007fe800983b55 in raise () from /lib64/libc.so.6
 (gdb) bt
-#0  0x00007fe800983b55 in raise () from /lib64/libc.so.6
-#1  0x00007fe800985131 in abort () from /lib64/libc.so.6
-#2  0x00007fe7ffe2437a in __osafassert_fail () from /usr/lib64/libopensaf_core.so.0
-#3  0x00007fe7ffe204b3 in osaf_extended_name_length () from /usr/lib64/libopensaf_core.so.0
-#4  0x00007fe8000a2dac in saImmOmAdminOperationInvoke_o2 () at imma_om_api.c:3569
+  #0  0x00007fe800983b55 in raise () from /lib64/libc.so.6
+  #1  0x00007fe800985131 in abort () from /lib64/libc.so.6
+  #2  0x00007fe7ffe2437a in __osafassert_fail () from /usr/lib64/libopensaf_core.so.0
+  #3  0x00007fe7ffe204b3 in osaf_extended_name_length () from /usr/lib64/libopensaf_core.so.0
+  #4  0x00007fe8000a2dac in saImmOmAdminOperationInvoke_o2 () at imma_om_api.c:3569

 Till 4.5 INVALID_PARAM is returned to the application.
     

  • Anders Bjornerstedt

    Anders Bjornerstedt - 2015-04-09
    • status: unassigned --> assigned
    • assigned_to: Zoran Milinkovic
     

  • Zoran Milinkovic

    Zoran Milinkovic - 2015-04-10
    • status: assigned --> accepted
    • Part: - --> lib
    • Milestone: 4.5.2 --> 4.6.RC1
     

  • Zoran Milinkovic

    Zoran Milinkovic - 2015-04-10

    This problem is introduced in OpenSAF 4.6. More IMM functions are affected by this problem, not only saImmOmAdminOperationInvoke_o2().
    The check, if object name is a valid name, is missing before osaf_extended_name_length().

     

  • Zoran Milinkovic

    Zoran Milinkovic - 2015-04-10

    There are some parts of the code in OpenSAF 4.5 where the check is missing. The milestone is reverted to 4.5.2

     

  • Zoran Milinkovic

    Zoran Milinkovic - 2015-04-10
    • status: accepted --> review
    • Milestone: 4.6.RC1 --> 4.5.2
     

  • Zoran Milinkovic

    Zoran Milinkovic - 2015-04-10
    • status: review --> accepted
    • Milestone: 4.5.2 --> 4.6.RC1
     

  • Zoran Milinkovic

    Zoran Milinkovic - 2015-04-10
    • status: accepted --> review
    • Milestone: 4.6.RC1 --> 4.5.2
     

  • Zoran Milinkovic

    Zoran Milinkovic - 2015-04-10

    I unintentionally changed the milestone from 4.5 to 4.6, and changed the status from review to accepted.

    I change back to the right milestone and the status.

     

  • Zoran Milinkovic

    Zoran Milinkovic - 2015-04-14
    • status: review --> fixed
     

  • Zoran Milinkovic

    Zoran Milinkovic - 2015-04-14

    opensaf-4.5.x:

    changeset: 6475:9efc31715bdf
    branch: opensaf-4.5.x
    parent: 6472:3afd398b3d36
    user: Zoran Milinkovic zoran.milinkovic@ericsson.com
    date: Fri Apr 10 14:12:58 2015 +0200
    summary: imm: validate SaNameT value before osaf_extended_name_length [#1303]

    opensaf-4.6.x:

    changeset: 6476:712340762044
    branch: opensaf-4.6.x
    parent: 6473:46e07c8e11c9
    user: Zoran Milinkovic zoran.milinkovic@ericsson.com
    date: Fri Apr 10 14:15:49 2015 +0200
    summary: imm: validate SaNameT value before osaf_extended_name_length [#1303]

    default(4.7):

    changeset: 6477:29cbb9e3c859
    tag: tip
    parent: 6474:4307262dd0d8
    user: Zoran Milinkovic zoran.milinkovic@ericsson.com
    date: Fri Apr 10 14:15:49 2015 +0200
    summary: imm: validate SaNameT value before osaf_extended_name_length [#1303]

     

    Related

    Tickets: #1303

Log in to post a comment.