#1146 smfd crashed on 2pbe setup while active controller coming up

[surender khetavath]

changeset : 5918
2PBE enabled

Test:
A campaign is modelled to add a new comp in each SU and a csi in each SI
execute the campaign
roll it back
Now stop opensaf on all payloads and standby controller
reboot the active controller.
smfd will crash with below bt

(gdb) bt

0 0x00007f05a64c0b55 in raise () from /lib64/libc.so.6

1 0x00007f05a64c2131 in abort () from /lib64/libc.so.6

2 0x00007f05a88b2fee in __osafassert_fail () from /usr/lib64/libopensaf_core.so.0

3 0x000000000041505d in updateImmAttr () at smfd_campaign_oi.cc:725

4 0x0000000000411dcc in SmfCampaign::setExpectedTime(long long) () at SmfCampaign.cc:761

5 0x00000000004115ee in SmfCampaign::initExecution() () at SmfCampaign.cc:627

6 0x000000000040d96c in SmfCampaignThread::main() () at SmfCampaignThread.cc:725

7 0x000000000040c244 in SmfCampaignThread::main(void*) () at SmfCampaignThread.cc:109

8 0x00007f05a73bc7b6 in start_thread () from /lib64/libpthread.so.0

9 0x00007f05a65659cd in clone () from /lib64/libc.so.6

10 0x0000000000000000 in ?? ()

(gdb) bt full

0 0x00007f05a64c0b55 in raise () from /lib64/libc.so.6

No symbol table info available.

1 0x00007f05a64c2131 in abort () from /lib64/libc.so.6

No symbol table info available.

2 0x00007f05a88b2fee in __osafassert_fail () from /usr/lib64/libopensaf_core.so.0

    mbcsv_init_process_req_func = {0x7f05a88c41a0 <mbcsv_process_initialize_request>,
      0x7f05a88c5a80 <mbcsv_process_get_sel_obj_request>, 0x7f05a88c4750 <mbcsv_process_dispatch_request>,
      0x7f05a88c4660 <mbcsv_process_finalize_request>, 0x7f05a88c4860 <mbcsv_process_open_request>,
      0x7f05a88c4bc0 <mbcsv_process_close_request>, 0x7f05a88c4d50 <mbcsv_process_chg_role_request>,
      0x7f05a88c5030 <mbcsv_process_snd_ckpt_request>, 0x7f05a88c5340 <mbcsv_process_snd_ntfy_request>,
      0x7f05a88c54e0 <mbcsv_process_snd_data_req>, 0x7f05a88c44a0 <mbcsv_process_get_request>,
      0x7f05a88c5740 <mbcsv_process_set_request>}

3 0x000000000041505d in updateImmAttr () at smfd_campaign_oi.cc:725

    campaignClassName = 0x489f43 "SaSmfCampaign"
    immVersion = {releaseCode = 65 'A', majorVersion = 2 '\002', minorVersion = 1 '\001'}
    smfConfigClassName = 0x489f8b "OpenSafSmfConfig"
    smfSwBundleClassName = 0x489f64 "SaSmfSwBundle"
    implementerName = 0x48a7da "safSmfService"
    callbacks = {
      saImmOiAdminOperationCallback = 0x412d38 <saImmOiAdminOperationCallback(unsigned long long, unsigned long long, SaNameT const*, unsigned long long, SaImmAdminOperationParamsT_2 const**)>,
      saImmOiCcbAbortCallback = 0x4149f1 <saImmOiCcbAbortCallback(unsigned long long, unsigned long long)>,
      saImmOiCcbApplyCallback = 0x414679 <saImmOiCcbApplyCallback(unsigned long long, unsigned long long)>,
      saImmOiCcbCompletedCallback = 0x4131b7 <saImmOiCcbCompletedCallback(unsigned long long, unsigned long long)>,
      saImmOiCcbObjectCreateCallback = 0x412e49 <saImmOiCcbObjectCreateCallback(unsigned long long, unsigned long long, char*, SaNameT const*, SaImmAttrValuesT_2 const**)>,
      saImmOiCcbObjectDeleteCallback = 0x412f8f <saImmOiCcbObjectDeleteCallback(unsigned long long, unsigned ---Type <return> to continue, or q <return> to quit---

long long, SaNameT const*)>,
saImmOiCcbObjectModifyCallback = 0x41307e <saimmoiccbobjectmodifycallback(unsigned saimmattrmodificationt_2="" unsigned="" long="" const*,="" const**)="" long,="" sanamet="">,
saImmOiRtAttrUpdateCallback = 0x414aa8 <saimmoirtattrupdatecallback(unsigned long="" const*,="" char*="" const*)="" long,="" sanamet="">}</saimmoirtattrupdatecallback(unsigned></saimmoiccbobjectmodifycallback(unsigned>

4 0x0000000000411dcc in SmfCampaign::setExpectedTime(long long) () at SmfCampaign.cc:761

    SmfCampaignList::s_instance = 0x6ed2f0

5 0x00000000004115ee in SmfCampaign::initExecution() () at SmfCampaign.cc:627

    SmfCampaignList::s_instance = 0x6ed2f0

6 0x000000000040d96c in SmfCampaignThread::main() () at SmfCampaignThread.cc:725

    SmfCampaignThread::s_instance = 0x6efb30

7 0x000000000040c244 in SmfCampaignThread::main(void*) () at SmfCampaignThread.cc:109

    SmfCampaignThread::s_instance = 0x6efb30

8 0x00007f05a73bc7b6 in start_thread () from /lib64/libpthread.so.0

No symbol table info available.

9 0x00007f05a65659cd in clone () from /lib64/libc.so.6

No symbol table info available.

10 0x0000000000000000 in ?? ()

No symbol table info available.
(gdb)

[surender khetavath]

sc-1 logs attached

[Robert Apanowicz]

The problem described by this ticket is solved by #1253.
Details:
The above backtrace points to an assert which happened because not all of the return codes handled (in that specific function where it happened). Now with #1253 the problem is fixed.