Menu

#1094 imm: missing NULL check in imma_xx_resurrect

4.3.3
fixed
None
defect
imm
-
major
2014-09-19
2014-09-16
No

In imma_om_resurrect and imma_oi_resurrect, imma_client_node_get may set cl_node to NULL, and later usage of cl_node may cause uncertain behavior.

imma_om_resurrect:

     imma_client_node_get(&cb->client_tree, &immHandle, &cl_node);
     if (cl_node && cl_node->isOm)
     {
             cl_node->stale = true;
             cl_node->exposed = true;
     } else {
             TRACE_3("client_node_get failed");
     }
     timeout = cl_node->syncr_timeout;

imma_oi_resurrect:

     imma_client_node_get(&cb->client_tree, &immOiHandle, &cl_node);
     if (cl_node && !cl_node->isOm) {
             cl_node->stale = true;
             cl_node->exposed = true;
     } else {
             TRACE_3("client_node_get failed");
     }

     timeout = cl_node->syncr_timeout;

Related

Tickets: #1094
Wiki: ChangeLog-4.3.3
Wiki: ChangeLog-4.4.1

Discussion

  • Neelakanta Reddy

    • status: unassigned --> accepted
    • assigned_to: Neelakanta Reddy
     
  • Neelakanta Reddy

    • status: accepted --> review
     
  • Neelakanta Reddy

    • status: review --> fixed
     

Log in to post a comment.