From: Zoran M. <zor...@er...> - 2017-08-17 13:03:56
|
Summary: imm: change log level from error to warning in PBE [#2559] Review request for Ticket(s): 2559 Peer Reviewer(s): Hung, Mahesh Pull request to: Zoran Affected branch(es): develop, release Development branch: ticket-2559 Base revision: e78203f0153360806c318e59b47845d438b3382e Personal repository: git://git.code.sf.net/u/zmilinkovic/review -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- revision 7a9c27240d74b3d0c2df8733663687665ec6729d Author: Zoran Milinkovic <zor...@er...> Date: Thu, 17 Aug 2017 14:53:23 +0200 imm: change log level from error to warning in PBE [#2559] In #2491, the log message if logged always with error log level. If a cluster goes headless, this case is very likely to be happen with ERR_TRY_AGAIN, but that's expected behavior when the cluster goes headless. Complete diffstat: ------------------ src/imm/common/immpbe_dump.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) Testing Commands: ----------------- Testing, Expected Results: -------------------------- Check that the log message is logged with warning log level when the cluster goes headless. Conditions of Submission: ------------------------- Ack from Hung and Mahesh Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.gitconfig file (i.e. user.name, user.email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. |
From: Zoran M. <zor...@er...> - 2017-08-17 13:04:02
|
In #2491, the log message if logged always with error log level. If a cluster goes headless, this case is very likely to be happen with ERR_TRY_AGAIN, but that's expected behavior when the cluster goes headless. --- src/imm/common/immpbe_dump.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/imm/common/immpbe_dump.cc b/src/imm/common/immpbe_dump.cc index 4c2b2ea..3d7c57e 100644 --- a/src/imm/common/immpbe_dump.cc +++ b/src/imm/common/immpbe_dump.cc @@ -1276,9 +1276,15 @@ static ClassInfo *verifyClassPBE(std::string classNameString, if (errorCode != SA_AIS_OK) { if (errorCode != SA_AIS_ERR_NOT_EXIST && errorCode != SA_AIS_ERR_INVALID_PARAM) { - LOG_ER("Failed to get class description for class '%s' from imm " - "with error=%d, exiting", - classNameString.c_str(), errorCode); + if(errorCode == SA_AIS_ERR_TRY_AGAIN) { + LOG_WA("Failed to get class description for class '%s' from imm " + "with error=%d, exiting", + classNameString.c_str(), errorCode); + } else { + LOG_ER("Failed to get class description for class '%s' from imm " + "with error=%d, exiting", + classNameString.c_str(), errorCode); + } exit(1); } TRACE_4( -- 1.9.1 |
From: A V M. <mah...@or...> - 2017-08-18 03:16:08
|
ACK, Not tested. -AVM On 8/17/2017 6:33 PM, Zoran Milinkovic wrote: > In #2491, the log message if logged always with error log level. > If a cluster goes headless, this case is very likely to be happen > with ERR_TRY_AGAIN, but that's expected behavior when the cluster > goes headless. > --- > src/imm/common/immpbe_dump.cc | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/src/imm/common/immpbe_dump.cc b/src/imm/common/immpbe_dump.cc > index 4c2b2ea..3d7c57e 100644 > --- a/src/imm/common/immpbe_dump.cc > +++ b/src/imm/common/immpbe_dump.cc > @@ -1276,9 +1276,15 @@ static ClassInfo *verifyClassPBE(std::string classNameString, > if (errorCode != SA_AIS_OK) { > if (errorCode != SA_AIS_ERR_NOT_EXIST > && errorCode != SA_AIS_ERR_INVALID_PARAM) { > - LOG_ER("Failed to get class description for class '%s' from imm " > - "with error=%d, exiting", > - classNameString.c_str(), errorCode); > + if(errorCode == SA_AIS_ERR_TRY_AGAIN) { > + LOG_WA("Failed to get class description for class '%s' from imm " > + "with error=%d, exiting", > + classNameString.c_str(), errorCode); > + } else { > + LOG_ER("Failed to get class description for class '%s' from imm " > + "with error=%d, exiting", > + classNameString.c_str(), errorCode); > + } > exit(1); > } > TRACE_4( |
From: Hung N. <hun...@de...> - 2017-08-18 06:41:12
|
Hi Zoran, Reviewed and tested the patch. Ack from me. BR, Hung Nguyen - DEK Technologies -------------------------------------------------------------------------------- From: Zoran Milinkovic zor...@er... Sent: Thursday, August 17, 2017 8:03PM To: Mahesh Valla mah...@or... Cc: Opensaf-devel ope...@li... Subject: [devel] [PATCH 1/1] imm: change log level from error to warning in PBE [#2559] In #2491, the log message if logged always with error log level. If a cluster goes headless, this case is very likely to be happen with ERR_TRY_AGAIN, but that's expected behavior when the cluster goes headless. --- src/imm/common/immpbe_dump.cc | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/imm/common/immpbe_dump.cc b/src/imm/common/immpbe_dump.cc index 4c2b2ea..3d7c57e 100644 --- a/src/imm/common/immpbe_dump.cc +++ b/src/imm/common/immpbe_dump.cc @@ -1276,9 +1276,15 @@ static ClassInfo *verifyClassPBE(std::string classNameString, if (errorCode != SA_AIS_OK) { if (errorCode != SA_AIS_ERR_NOT_EXIST && errorCode != SA_AIS_ERR_INVALID_PARAM) { - LOG_ER("Failed to get class description for class '%s' from imm " - "with error=%d, exiting", - classNameString.c_str(), errorCode); + if(errorCode == SA_AIS_ERR_TRY_AGAIN) { + LOG_WA("Failed to get class description for class '%s' from imm " + "with error=%d, exiting", + classNameString.c_str(), errorCode); + } else { + LOG_ER("Failed to get class description for class '%s' from imm " + "with error=%d, exiting", + classNameString.c_str(), errorCode); + } exit(1); } TRACE_4( |